Minor fixes and tweaks

utils/flags.go

@@ -5,7 +5,9 @@ import (
 )
 
 var (
+	// Deprecated
 	GitFlag       = flag.Bool("git", false, "Use git to manage files")
+	// Deprecated
 	ResetFlag     = flag.Bool("reset", false, "Reset files to their original state")
 	LogLevel      = flag.String("loglevel", "INFO", "Set log level: ERROR, WARNING, INFO, DEBUG, TRACE")
 	Cookfile      = flag.String("cook", "**/cook.yml", "Path to cook config files, can be globbed")

utils/modifycommand.go

@@ -124,7 +124,10 @@ func LoadCommands(args []string) ([]ModifyCommand, error) {
 	logger.Info("Loading commands from arguments: %v", args)
 	newcommands, err = LoadCommandFromArgs(args)
 	if err != nil {
-		return nil, fmt.Errorf("failed to load commands from args: %w", err)
+		if len(commands) == 0 {
+			return nil, fmt.Errorf("failed to load commands from args: %w", err)
+		}
+		logger.Warning("Failed to load commands from args: %v", err)
 	}
 	logger.Info("Successfully loaded %d commands from args", len(newcommands))
 	commands = append(commands, newcommands...)
@@ -166,7 +169,7 @@ func LoadCommandsFromCookFiles(s string) ([]ModifyCommand, error) {
 	}
 
 	commands := []ModifyCommand{}
-	cookFiles, err := doublestar.Glob(os.DirFS(cwd), "*.yaml")
+	cookFiles, err := doublestar.Glob(os.DirFS(cwd), *Cookfile)
 	if err != nil {
 		return nil, fmt.Errorf("failed to glob cook files: %w", err)
 	}

utils/modifycommand_test.go

@@ -523,6 +523,36 @@ func TestLoadCommandsFromCookFileWithMultipleEntries(t *testing.T) {
 	assert.Equal(t, "append", commands[2].Lua)
 }
 
+func TestLoadCommandsFromCookFileLegitExample(t *testing.T) {
+	// Arrange
+	yamlData := []byte(`
+- name: crewlayabout
+  pattern: '<Talent identifier="crewlayabout">!anyvalue="(?<repairspeedpenalty>!num)"!anyvalue="(?<skillpenalty>!num)"!anyvalue="(?<repairspeedbonus>!num)"!anyvalue="(?<skillbonus>!num)"!anydistance="(?<distance>!num)"!anySkillBonus!anyvalue="(?<skillpenaltyv>!num)"!anyvalue="(?<skillpenaltyv1>!num)"!anyvalue="(?<skillpenaltyv2>!num)"!anyvalue="(?<skillpenaltyv3>!num)"!anyvalue="(?<skillpenaltyv4>!num)"!anyvalue="(?<repairspeedpenaltyv>!num)'
+  lua: |
+    repairspeedpenalty=round(repairspeedpenalty/2, 2)
+    skillpenalty=round(skillpenalty/2, 0)
+    repairspeedbonus=round(repairspeedbonus*2, 2)
+    skillbonus=round(skillbonus*2, 0)
+    distance=round(distance*2, 0)
+    skillpenaltyv=skillpenalty
+    skillpenaltyv1=skillpenalty
+    skillpenaltyv2=skillpenalty
+    skillpenaltyv3=skillpenalty
+    skillpenaltyv4=skillpenalty
+    repairspeedpenaltyv=round(-repairspeedpenalty/100, 2)
+  files:
+    - '**/TalentsAssistant.xml'
+`)
+
+	// Act
+	commands, err := LoadCommandsFromCookFile(yamlData)
+
+	// Assert
+	assert.NoError(t, err)
+	assert.Len(t, commands, 1)
+	assert.Equal(t, "crewlayabout", commands[0].Name)
+}
+
 // Valid command with minimum 3 arguments returns a ModifyCommand slice with correct values
 func TestLoadCommandFromArgsWithValidArguments(t *testing.T) {
 	// Setup