diff --git a/main.go b/main.go index 9921e8c..b6146d7 100644 --- a/main.go +++ b/main.go @@ -7,6 +7,7 @@ import ( "os" "sort" "sync" + "sync/atomic" "time" "cook/processor" @@ -18,10 +19,10 @@ import ( ) type GlobalStats struct { - TotalMatches int - TotalModifications int - ProcessedFiles int - FailedFiles int + TotalMatches int64 + TotalModifications int64 + ProcessedFiles int64 + FailedFiles int64 ModificationsPerCommand sync.Map } @@ -138,7 +139,6 @@ func main() { // Add performance tracking startTime := time.Now() - var fileMutex sync.Mutex // Create a map to store loggers for each command commandLoggers := make(map[string]*logger.Logger) @@ -177,15 +177,17 @@ func main() { fileData, err := os.ReadFile(file) if err != nil { logger.Error("Failed to read file %q: %v", file, err) + atomic.AddInt64(&stats.FailedFiles, 1) return } fileDataStr := string(fileData) isChanged := false logger.Debug("Running isolate commands for file %q", file) - fileDataStr, err = RunIsolateCommands(association, file, fileDataStr, &fileMutex) + fileDataStr, err = RunIsolateCommands(association, file, fileDataStr) if err != nil && err != NothingToDo { logger.Error("Failed to run isolate commands for file %q: %v", file, err) + atomic.AddInt64(&stats.FailedFiles, 1) return } if err != NothingToDo { @@ -193,9 +195,10 @@ func main() { } logger.Debug("Running other commands for file %q", file) - fileDataStr, err = RunOtherCommands(file, fileDataStr, association, &fileMutex, commandLoggers) + fileDataStr, err = RunOtherCommands(file, fileDataStr, association, commandLoggers) if err != nil && err != NothingToDo { logger.Error("Failed to run other commands for file %q: %v", file, err) + atomic.AddInt64(&stats.FailedFiles, 1) return } if err != NothingToDo { @@ -207,6 +210,7 @@ func main() { err = db.SaveFile(file, fileData) if err != nil { logger.Error("Failed to save file %q to database: %v", file, err) + atomic.AddInt64(&stats.FailedFiles, 1) return } } @@ -215,9 +219,13 @@ func main() { err = os.WriteFile(file, []byte(fileDataStr), 0644) if err != nil { logger.Error("Failed to write file %q: %v", file, err) + atomic.AddInt64(&stats.FailedFiles, 1) return } + // Only increment ProcessedFiles once per file, after all processing is complete + atomic.AddInt64(&stats.ProcessedFiles, 1) + logger.Debug("File %q processed in %v", file, time.Since(fileStartTime)) }, file, commands) } @@ -225,8 +233,9 @@ func main() { processingTime := time.Since(startTime) logger.Info("Processing completed in %v", processingTime) - if stats.ProcessedFiles > 0 { - logger.Info("Average time per file: %v", processingTime/time.Duration(stats.ProcessedFiles)) + processedFiles := atomic.LoadInt64(&stats.ProcessedFiles) + if processedFiles > 0 { + logger.Info("Average time per file: %v", processingTime/time.Duration(processedFiles)) } // TODO: Also give each command its own logger, maybe prefix it with something... Maybe give commands a name? @@ -269,11 +278,13 @@ func main() { // } // Print summary - if stats.TotalModifications == 0 { + totalModifications := atomic.LoadInt64(&stats.TotalModifications) + if totalModifications == 0 { logger.Warning("No modifications were made in any files") } else { + failedFiles := atomic.LoadInt64(&stats.FailedFiles) logger.Info("Operation complete! Modified %d values in %d/%d files", - stats.TotalModifications, stats.ProcessedFiles, stats.ProcessedFiles+stats.FailedFiles) + totalModifications, processedFiles, processedFiles+failedFiles) sortedCommands := []string{} stats.ModificationsPerCommand.Range(func(key, value interface{}) bool { sortedCommands = append(sortedCommands, key.(string)) @@ -358,7 +369,7 @@ func CreateExampleConfig() { var NothingToDo = errors.New("nothing to do") -func RunOtherCommands(file string, fileDataStr string, association utils.FileCommandAssociation, fileMutex *sync.Mutex, commandLoggers map[string]*logger.Logger) (string, error) { +func RunOtherCommands(file string, fileDataStr string, association utils.FileCommandAssociation, commandLoggers map[string]*logger.Logger) (string, error) { // Aggregate all the modifications and execute them modifications := []utils.ReplaceCommand{} for _, command := range association.Commands { @@ -396,16 +407,13 @@ func RunOtherCommands(file string, fileDataStr string, association utils.FileCom var count int fileDataStr, count = utils.ExecuteModifications(modifications, fileDataStr) - fileMutex.Lock() - stats.ProcessedFiles++ - stats.TotalModifications += count - fileMutex.Unlock() + atomic.AddInt64(&stats.TotalModifications, int64(count)) logger.Info("Executed %d modifications for file %q", count, file) return fileDataStr, nil } -func RunIsolateCommands(association utils.FileCommandAssociation, file string, fileDataStr string, fileMutex *sync.Mutex) (string, error) { +func RunIsolateCommands(association utils.FileCommandAssociation, file string, fileDataStr string) (string, error) { anythingDone := false for _, isolateCommand := range association.IsolateCommands { logger.Info("Processing file %q with isolate command %q", file, isolateCommand.Regex) @@ -424,10 +432,7 @@ func RunIsolateCommands(association utils.FileCommandAssociation, file string, f var count int fileDataStr, count = utils.ExecuteModifications(modifications, fileDataStr) - fileMutex.Lock() - stats.ProcessedFiles++ - stats.TotalModifications += count - fileMutex.Unlock() + atomic.AddInt64(&stats.TotalModifications, int64(count)) logger.Info("Executed %d isolate modifications for file %q", count, file) }