Remove some unused shit and write tests for coverage

processor/json.go

@@ -331,7 +331,14 @@ func convertValueToJSONString(value interface{}) string {
 // findArrayElementRemovalRange finds the exact byte range to remove for an array element
 func findArrayElementRemovalRange(content, arrayPath string, elementIndex int) (int, int) {
 	// Get the array using gjson
-	arrayResult := gjson.Get(content, arrayPath)
+	var arrayResult gjson.Result
+	if arrayPath == "" {
+		// Root-level array
+		arrayResult = gjson.Parse(content)
+	} else {
+		arrayResult = gjson.Get(content, arrayPath)
+	}
+
 	if !arrayResult.Exists() || !arrayResult.IsArray() {
 		return -1, -1
 	}
@@ -455,16 +462,9 @@ func findDeepChanges(basePath string, original, modified interface{}) map[string
 				}
 			}
 		}
-	default:
-		// For primitive types, compare directly
-		if !deepEqual(original, modified) {
-			if basePath == "" {
-				changes[""] = modified
-			} else {
-				changes[basePath] = modified
-			}
-		}
 	}
+	// Note: No default case needed - JSON data from unmarshaling is always
+	// map[string]interface{} or []interface{} at the top level
 
 	return changes
 }
@@ -531,112 +531,61 @@ func deepEqual(a, b interface{}) bool {
 	}
 }
 
-// ToLuaTable converts a Go interface{} to a Lua table recursively
+// ToLuaTable converts a Go interface{} (map or array) to a Lua table
+// This should only be called with map[string]interface{} or []interface{} from JSON unmarshaling
 func ToLuaTable(L *lua.LState, data interface{}) (*lua.LTable, error) {
-	toLuaTableLogger := jsonLogger.WithPrefix("ToLuaTable")
-	toLuaTableLogger.Debug("Converting Go interface to Lua table")
-	toLuaTableLogger.Trace("Input data type: %T", data)
-
 	switch v := data.(type) {
 	case map[string]interface{}:
-		toLuaTableLogger.Debug("Converting map to Lua table")
 		table := L.CreateTable(0, len(v))
 		for key, value := range v {
-			luaValue, err := ToLuaValue(L, value)
-			if err != nil {
-				toLuaTableLogger.Error("Failed to convert map value for key %q: %v", key, err)
-				return nil, err
-			}
-			table.RawSetString(key, luaValue)
+			table.RawSetString(key, ToLuaValue(L, value))
 		}
 		return table, nil
 
 	case []interface{}:
-		toLuaTableLogger.Debug("Converting slice to Lua table")
 		table := L.CreateTable(len(v), 0)
 		for i, value := range v {
-			luaValue, err := ToLuaValue(L, value)
-			if err != nil {
-				toLuaTableLogger.Error("Failed to convert slice value at index %d: %v", i, err)
-				return nil, err
-			}
-			table.RawSetInt(i+1, luaValue) // Lua arrays are 1-indexed
+			table.RawSetInt(i+1, ToLuaValue(L, value)) // Lua arrays are 1-indexed
 		}
 		return table, nil
 
-	case string:
-		toLuaTableLogger.Debug("Converting string to Lua string")
-		return nil, fmt.Errorf("expected table or array, got string")
-
-	case float64:
-		toLuaTableLogger.Debug("Converting float64 to Lua number")
-		return nil, fmt.Errorf("expected table or array, got number")
-
-	case bool:
-		toLuaTableLogger.Debug("Converting bool to Lua boolean")
-		return nil, fmt.Errorf("expected table or array, got boolean")
-
-	case nil:
-		toLuaTableLogger.Debug("Converting nil to Lua nil")
-		return nil, fmt.Errorf("expected table or array, got nil")
-
 	default:
-		toLuaTableLogger.Error("Unsupported type for Lua table conversion: %T", v)
-		return nil, fmt.Errorf("unsupported type for Lua table conversion: %T", v)
+		// This should only happen with invalid JSON (root-level primitives)
+		return nil, fmt.Errorf("expected table or array, got %T", v)
 	}
 }
 
 // ToLuaValue converts a Go interface{} to a Lua value
-func ToLuaValue(L *lua.LState, data interface{}) (lua.LValue, error) {
-	toLuaValueLogger := jsonLogger.WithPrefix("ToLuaValue")
-	toLuaValueLogger.Debug("Converting Go interface to Lua value")
-	toLuaValueLogger.Trace("Input data type: %T", data)
-
+func ToLuaValue(L *lua.LState, data interface{}) lua.LValue {
 	switch v := data.(type) {
 	case map[string]interface{}:
-		toLuaValueLogger.Debug("Converting map to Lua table")
 		table := L.CreateTable(0, len(v))
 		for key, value := range v {
-			luaValue, err := ToLuaValue(L, value)
-			if err != nil {
-				toLuaValueLogger.Error("Failed to convert map value for key %q: %v", key, err)
-				return lua.LNil, err
-			}
-			table.RawSetString(key, luaValue)
+			table.RawSetString(key, ToLuaValue(L, value))
 		}
-		return table, nil
+		return table
 
 	case []interface{}:
-		toLuaValueLogger.Debug("Converting slice to Lua table")
 		table := L.CreateTable(len(v), 0)
 		for i, value := range v {
-			luaValue, err := ToLuaValue(L, value)
-			if err != nil {
-				toLuaValueLogger.Error("Failed to convert slice value at index %d: %v", i, err)
-				return lua.LNil, err
-			}
-			table.RawSetInt(i+1, luaValue) // Lua arrays are 1-indexed
+			table.RawSetInt(i+1, ToLuaValue(L, value)) // Lua arrays are 1-indexed
 		}
-		return table, nil
+		return table
 
 	case string:
-		toLuaValueLogger.Debug("Converting string to Lua string")
-		return lua.LString(v), nil
+		return lua.LString(v)
 
 	case float64:
-		toLuaValueLogger.Debug("Converting float64 to Lua number")
-		return lua.LNumber(v), nil
+		return lua.LNumber(v)
 
 	case bool:
-		toLuaValueLogger.Debug("Converting bool to Lua boolean")
-		return lua.LBool(v), nil
+		return lua.LBool(v)
 
 	case nil:
-		toLuaValueLogger.Debug("Converting nil to Lua nil")
-		return lua.LNil, nil
+		return lua.LNil
 
 	default:
-		toLuaValueLogger.Error("Unsupported type for Lua value conversion: %T", v)
-		return lua.LNil, fmt.Errorf("unsupported type for Lua value conversion: %T", v)
+		// This should never happen with JSON-unmarshaled data
+		return lua.LNil
 	}
 }