From 09dfbde676e14e783db66b3b04cc1be59518312f Mon Sep 17 00:00:00 2001 From: peaklabs-dev <122374094+peaklabs-dev@users.noreply.github.com> Date: Mon, 6 Jan 2025 21:14:06 +0100 Subject: [PATCH] chore: remove debug log, finally found it --- app/Jobs/GithubAppPermissionJob.php | 25 ------------------------- bootstrap/helpers/github.php | 27 --------------------------- 2 files changed, 52 deletions(-) diff --git a/app/Jobs/GithubAppPermissionJob.php b/app/Jobs/GithubAppPermissionJob.php index 89c3daa12..d6da4439c 100644 --- a/app/Jobs/GithubAppPermissionJob.php +++ b/app/Jobs/GithubAppPermissionJob.php @@ -27,17 +27,9 @@ class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue public function handle() { - Log::debug('Starting GithubAppPermissionJob', [ - 'app_id' => $this->github_app->app_id, - 'installation_id' => $this->github_app->installation_id, - 'api_url' => $this->github_app->api_url, - ]); - try { - Log::debug('Generating GitHub JWT token'); $github_access_token = generateGithubJwt($this->github_app); - Log::debug('Fetching app permissions from GitHub API'); $response = Http::withHeaders([ 'Authorization' => "Bearer $github_access_token", 'Accept' => 'application/vnd.github+json', @@ -55,31 +47,14 @@ class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue $response = $response->json(); $permissions = data_get($response, 'permissions'); - Log::debug('Retrieved GitHub permissions', [ - 'app_id' => $this->github_app->app_id, - 'permissions' => $permissions, - ]); - $this->github_app->contents = data_get($permissions, 'contents'); $this->github_app->metadata = data_get($permissions, 'metadata'); $this->github_app->pull_requests = data_get($permissions, 'pull_requests'); $this->github_app->administration = data_get($permissions, 'administration'); - Log::debug('Saving updated permissions to database', [ - 'app_id' => $this->github_app->app_id, - 'contents' => $this->github_app->contents, - 'metadata' => $this->github_app->metadata, - 'pull_requests' => $this->github_app->pull_requests, - 'administration' => $this->github_app->administration, - ]); - $this->github_app->save(); $this->github_app->makeVisible('client_secret')->makeVisible('webhook_secret'); - Log::debug('Successfully completed GithubAppPermissionJob', [ - 'app_id' => $this->github_app->app_id, - ]); - } catch (\Throwable $e) { Log::error('GithubAppPermissionJob failed', [ 'app_id' => $this->github_app->app_id, diff --git a/bootstrap/helpers/github.php b/bootstrap/helpers/github.php index be4ae65c5..168308967 100644 --- a/bootstrap/helpers/github.php +++ b/bootstrap/helpers/github.php @@ -15,23 +15,11 @@ use Lcobucci\JWT\Token\Builder; function generateGithubToken(GithubApp $source, string $type) { - Log::debug('Generating GitHub token', [ - 'app_id' => $source->app_id, - 'type' => $type, - 'api_url' => $source->api_url, - ]); - $response = Http::get("{$source->api_url}/zen"); $serverTime = CarbonImmutable::now()->setTimezone('UTC'); $githubTime = Carbon::parse($response->header('date')); $timeDiff = abs($serverTime->diffInSeconds($githubTime)); - Log::debug('Time synchronization check', [ - 'server_time' => $serverTime->format('Y-m-d H:i:s'), - 'github_time' => $githubTime->format('Y-m-d H:i:s'), - 'difference_seconds' => $timeDiff, - ]); - if ($timeDiff > 50) { Log::error('System time out of sync with GitHub', [ 'time_difference' => $timeDiff, @@ -60,20 +48,9 @@ function generateGithubToken(GithubApp $source, string $type) ->getToken($algorithm, $signingKey) ->toString(); - Log::debug('JWT token generated', [ - 'token_type' => $type, - 'issued_at' => $now->modify('-1 minute')->format('Y-m-d H:i:s'), - 'expires_at' => $now->modify('+8 minutes')->format('Y-m-d H:i:s'), - ]); - return match ($type) { 'jwt' => $jwt, 'installation' => (function () use ($source, $jwt) { - Log::debug('Requesting installation token', [ - 'app_id' => $source->app_id, - 'installation_id' => $source->installation_id, - ]); - $response = Http::withHeaders([ 'Authorization' => "Bearer $jwt", 'Accept' => 'application/vnd.github.machine-man-preview+json', @@ -89,10 +66,6 @@ function generateGithubToken(GithubApp $source, string $type) throw new RuntimeException("Failed to get installation token for {$source->name} with error: ".$error); } - Log::debug('Successfully obtained installation token', [ - 'app_id' => $source->app_id, - ]); - return $response->json()['token']; })(), default => throw new \InvalidArgumentException("Unsupported token type: {$type}")