From 2361c34a537e718cc373c4ec9b0eba69447faa12 Mon Sep 17 00:00:00 2001
From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com>
Date: Thu, 29 May 2025 10:49:55 +0200
Subject: [PATCH] refactor(error-handling): replace generic Exception with
 RuntimeException for improved error specificity

---
 app/Actions/Service/DeleteService.php | 2 +-
 app/Models/Application.php            | 2 +-
 bootstrap/helpers/shared.php          | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/Actions/Service/DeleteService.php b/app/Actions/Service/DeleteService.php
index 372ffe397..404e11559 100644
--- a/app/Actions/Service/DeleteService.php
+++ b/app/Actions/Service/DeleteService.php
@@ -53,7 +53,7 @@ class DeleteService
 
             instant_remote_process(["docker rm -f $service->uuid"], $server, throwError: false);
         } catch (\Exception $e) {
-            throw new \Exception($e->getMessage());
+            throw new \RuntimeException($e->getMessage());
         } finally {
             if ($deleteConfigurations) {
                 $service->deleteConfigurations();
diff --git a/app/Models/Application.php b/app/Models/Application.php
index 7929aadc1..f3f063d19 100644
--- a/app/Models/Application.php
+++ b/app/Models/Application.php
@@ -1289,7 +1289,7 @@ class Application extends BaseModel
         try {
             $yaml = Yaml::parse($this->docker_compose_raw);
         } catch (\Exception $e) {
-            throw new \Exception($e->getMessage());
+            throw new \RuntimeException($e->getMessage());
         }
         $services = data_get($yaml, 'services');
 
diff --git a/bootstrap/helpers/shared.php b/bootstrap/helpers/shared.php
index 7d6d55c5d..7e4dd121a 100644
--- a/bootstrap/helpers/shared.php
+++ b/bootstrap/helpers/shared.php
@@ -599,7 +599,7 @@ function getTopLevelNetworks(Service|Application $resource)
             try {
                 $yaml = Yaml::parse($resource->docker_compose_raw);
             } catch (\Exception $e) {
-                throw new \Exception($e->getMessage());
+                throw new \RuntimeException($e->getMessage());
             }
             $services = data_get($yaml, 'services');
             $topLevelNetworks = collect(data_get($yaml, 'networks', []));
@@ -653,7 +653,7 @@ function getTopLevelNetworks(Service|Application $resource)
         try {
             $yaml = Yaml::parse($resource->docker_compose_raw);
         } catch (\Exception $e) {
-            throw new \Exception($e->getMessage());
+            throw new \RuntimeException($e->getMessage());
         }
         $server = $resource->destination->server;
         $topLevelNetworks = collect(data_get($yaml, 'networks', []));
@@ -1435,7 +1435,7 @@ function parseDockerComposeFile(Service|Application $resource, bool $isNew = fal
             try {
                 $yaml = Yaml::parse($resource->docker_compose_raw);
             } catch (\Exception $e) {
-                throw new \Exception($e->getMessage());
+                throw new \RuntimeException($e->getMessage());
             }
             $allServices = get_service_templates();
             $topLevelVolumes = collect(data_get($yaml, 'volumes', []));