fix: deployment should fail on error

This commit is contained in:
Andras Bacsai
2023-04-04 14:23:10 +02:00
parent 91e4280f6b
commit 302f224bc0
2 changed files with 4 additions and 3 deletions

View File

@@ -71,6 +71,9 @@ class RunRemoteProcess
$this->activity->save(); $this->activity->save();
if ($processResult->exitCode() != 0 && $processResult->errorOutput()) {
throw new \RuntimeException('Remote command failed');
}
return $processResult; return $processResult;
} }

View File

@@ -279,15 +279,13 @@ class DeployApplicationJob implements ShouldQueue
'hideFromOutput' => $hideFromOutput, 'hideFromOutput' => $hideFromOutput,
'setStatus' => $setStatus, 'setStatus' => $setStatus,
]); ]);
$result = $remoteProcess();
if ($propertyName) { if ($propertyName) {
$result = $remoteProcess();
$this->activity->properties = $this->activity->properties->merge([ $this->activity->properties = $this->activity->properties->merge([
$propertyName => trim($result->output()), $propertyName => trim($result->output()),
]); ]);
$this->activity->save(); $this->activity->save();
} else {
$remoteProcess();
} }
} }
private function gitImport() private function gitImport()