From 31dd2176b2ffd17fa82cbc3ca17e034d0f481a8d Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@gmail.com>
Date: Fri, 8 Nov 2024 15:03:21 +0100
Subject: [PATCH] fix: github app name is too long

---
 app/Livewire/Source/Github/Create.php         |  2 +-
 .../new/github-private-repository.blade.php   |  2 +-
 .../shared/scheduled-task/all.blade.php       |  6 ++---
 resources/views/source/all.blade.php          |  2 +-
 resources/views/source/github/new.blade.php   |  4 ----
 resources/views/source/new.blade.php          | 22 -------------------
 6 files changed, 6 insertions(+), 32 deletions(-)
 delete mode 100644 resources/views/source/github/new.blade.php
 delete mode 100644 resources/views/source/new.blade.php

diff --git a/app/Livewire/Source/Github/Create.php b/app/Livewire/Source/Github/Create.php
index 103c5c9fb..136d3525e 100644
--- a/app/Livewire/Source/Github/Create.php
+++ b/app/Livewire/Source/Github/Create.php
@@ -23,7 +23,7 @@ class Create extends Component
 
     public function mount()
     {
-        $this->name = substr(generate_random_name(), 0, 34); // GitHub Apps names can only be 34 characters long
+        $this->name = substr(generate_random_name(), 0, 30);
     }
 
     public function createGitHubApp()
diff --git a/resources/views/livewire/project/new/github-private-repository.blade.php b/resources/views/livewire/project/new/github-private-repository.blade.php
index b4ef1bdb1..b390189fc 100644
--- a/resources/views/livewire/project/new/github-private-repository.blade.php
+++ b/resources/views/livewire/project/new/github-private-repository.blade.php
@@ -1,7 +1,7 @@
 <div>
     <div class="flex items-end gap-2">
         <h1>Create a new Application</h1>
-        <x-modal-input buttonTitle="+ Add GitHub App" title="New GitHub App">
+        <x-modal-input buttonTitle="+ Add GitHub App" title="New GitHub App" closeOutside="false">
             <livewire:source.github.create />
         </x-modal-input>
         @if ($repositories->count() > 0)
diff --git a/resources/views/livewire/project/shared/scheduled-task/all.blade.php b/resources/views/livewire/project/shared/scheduled-task/all.blade.php
index 1d34447f6..42bbacb6d 100644
--- a/resources/views/livewire/project/shared/scheduled-task/all.blade.php
+++ b/resources/views/livewire/project/shared/scheduled-task/all.blade.php
@@ -1,11 +1,11 @@
 <div>
     <div class="flex gap-2">
         <h2>Scheduled Tasks</h2>
-        <x-modal-input buttonTitle="+ Add" title="New Scheduled Task" :closeOutside=false>
+        <x-modal-input buttonTitle="+ Add" title="New Scheduled Task" :closeOutside="false">
             @if ($resource->type() == 'application')
-                <livewire:project.shared.scheduled-task.add :type="$resource->type()" :containerNames="$containerNames"/>
+                <livewire:project.shared.scheduled-task.add :type="$resource->type()" :containerNames="$containerNames" />
             @elseif ($resource->type() == 'service')
-                <livewire:project.shared.scheduled-task.add :type="$resource->type()" :containerNames="$containerNames"/>
+                <livewire:project.shared.scheduled-task.add :type="$resource->type()" :containerNames="$containerNames" />
             @endif
         </x-modal-input>
     </div>
diff --git a/resources/views/source/all.blade.php b/resources/views/source/all.blade.php
index 989edf186..4d8002424 100644
--- a/resources/views/source/all.blade.php
+++ b/resources/views/source/all.blade.php
@@ -4,7 +4,7 @@
     </x-slot>
     <div class="flex items-start gap-2">
         <h1>Sources</h1>
-        <x-modal-input buttonTitle="+ Add" title="New GitHub App">
+        <x-modal-input buttonTitle="+ Add" title="New GitHub App" :closeOutside="false">
             <livewire:source.github.create />
         </x-modal-input>
     </div>
diff --git a/resources/views/source/github/new.blade.php b/resources/views/source/github/new.blade.php
deleted file mode 100644
index cb516e591..000000000
--- a/resources/views/source/github/new.blade.php
+++ /dev/null
@@ -1,4 +0,0 @@
-<x-layout>
-    <h1>New GitHub Source</h1>
-
-</x-layout>
diff --git a/resources/views/source/new.blade.php b/resources/views/source/new.blade.php
deleted file mode 100644
index 29359c5d7..000000000
--- a/resources/views/source/new.blade.php
+++ /dev/null
@@ -1,22 +0,0 @@
-<x-layout>
-    <h1>New Source</h1>
-    <div class="subtitle ">Add source providers for your applications.</div>
-    <div x-data="{ activeTab: window.location.hash ? window.location.hash.substring(1) : 'github' }">
-        {{-- <div class="flex justify-center h-full gap-2 pb-6">
-            <a class="flex items-center justify-center w-1/2 p-2 transition-colors rounded-none min-h-12 bg-coolgray-200 hover:bg-coollabs-100 hover:dark:text-white hover:no-underline"
-                :class="activeTab === 'github' && 'bg-coollabs dark:text-white'"
-                @click.prevent="activeTab = 'github'; window.location.hash = 'github'" href="#">GitHub
-            </a>
-            <a class="flex items-center justify-center w-1/2 p-2 transition-colors rounded-none min-h-12 bg-coolgray-200 hover:bg-coollabs-100 hover:dark:text-white hover:no-underline"
-                :class="activeTab === 'gitlab' && 'bg-coollabs dark:text-white'"
-                @click.prevent="activeTab = 'gitlab'; window.location.hash = 'gitlab'" href="#">GitLab
-            </a>
-        </div> --}}
-        <div x-cloak x-show="activeTab === 'github'" class="h-full">
-            <livewire:source.github.create />
-        </div>
-        {{-- <div x-cloak x-show="activeTab === 'gitlab'" class="h-full">
-            WIP
-        </div> --}}
-    </div>
-</x-layout>