feat(validation): centralize validation patterns for names and descriptions

- Introduced `ValidationPatterns` class to standardize validation rules and messages for name and description fields across the application. - Updated various components and models to utilize the new validation patterns, ensuring consistent sanitization and validation logic. - Replaced the `HasSafeNameAttribute` trait with `HasSafeStringAttribute` to enhance attribute handling and maintain consistency in name sanitization. - Enhanced the `CleanupNames` command to align with the new validation rules, allowing for a broader range of valid characters in names.
2025-08-19 12:14:48 +02:00
parent 0bb9ee4327
commit 38c0641734
30 changed files with 238 additions and 132 deletions
--- a/app/Support/ValidationPatterns.php
+++ b/app/Support/ValidationPatterns.php
@@ -0,0 +1,93 @@
+<?php
+
+namespace App\Support;
+
+/**
+ * Shared validation patterns for consistent use across the application
+ */
+class ValidationPatterns
+{
+    /**
+     * Pattern for names (allows letters, numbers, spaces, dashes, underscores, dots, slashes, colons, parentheses)
+     * Matches CleanupNames::sanitizeName() allowed characters
+     */
+    public const NAME_PATTERN = '/^[a-zA-Z0-9\s\-_.:\/()]+$/';
+
+    /**
+     * Pattern for descriptions (allows more characters including quotes, commas, etc.)
+     * More permissive than names but still restricts dangerous characters
+     */
+    public const DESCRIPTION_PATTERN = '/^[a-zA-Z0-9\s\-_.:\/()\'\",.!?@#%&+=\[\]{}|~`*]+$/';
+
+    /**
+     * Get validation rules for name fields
+     */
+    public static function nameRules(bool $required = true, int $minLength = 3, int $maxLength = 255): array
+    {
+        $rules = [];
+
+        if ($required) {
+            $rules[] = 'required';
+        } else {
+            $rules[] = 'nullable';
+        }
+
+        $rules[] = 'string';
+        $rules[] = "min:$minLength";
+        $rules[] = "max:$maxLength";
+        $rules[] = 'regex:'.self::NAME_PATTERN;
+
+        return $rules;
+    }
+
+    /**
+     * Get validation rules for description fields
+     */
+    public static function descriptionRules(bool $required = false, int $maxLength = 255): array
+    {
+        $rules = [];
+
+        if ($required) {
+            $rules[] = 'required';
+        } else {
+            $rules[] = 'nullable';
+        }
+
+        $rules[] = 'string';
+        $rules[] = "max:$maxLength";
+        $rules[] = 'regex:'.self::DESCRIPTION_PATTERN;
+
+        return $rules;
+    }
+
+    /**
+     * Get validation messages for name fields
+     */
+    public static function nameMessages(): array
+    {
+        return [
+            'name.regex' => 'The name may only contain letters, numbers, spaces, dashes (-), underscores (_), dots (.), slashes (/), colons (:), and parentheses ().',
+            'name.min' => 'The name must be at least :min characters.',
+            'name.max' => 'The name may not be greater than :max characters.',
+        ];
+    }
+
+    /**
+     * Get validation messages for description fields
+     */
+    public static function descriptionMessages(): array
+    {
+        return [
+            'description.regex' => 'The description contains invalid characters. Only letters, numbers, spaces, and common punctuation (- _ . : / () \' " , ! ? @ # % & + = [] {} | ~ ` *) are allowed.',
+            'description.max' => 'The description may not be greater than :max characters.',
+        ];
+    }
+
+    /**
+     * Get combined validation messages for both name and description fields
+     */
+    public static function combinedMessages(): array
+    {
+        return array_merge(self::nameMessages(), self::descriptionMessages());
+    }
+}