From 3c3333d3df8548ba3f79a030390dfead7bc80ed3 Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@gmail.com>
Date: Mon, 14 Feb 2022 09:47:09 +0100
Subject: [PATCH] fix: Validate secrets

---
 .../applications/[id]/secrets/_Secret.svelte     | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/routes/applications/[id]/secrets/_Secret.svelte b/src/routes/applications/[id]/secrets/_Secret.svelte
index efe0b7c1a..60c53080b 100644
--- a/src/routes/applications/[id]/secrets/_Secret.svelte
+++ b/src/routes/applications/[id]/secrets/_Secret.svelte
@@ -9,7 +9,8 @@
 	import { createEventDispatcher } from 'svelte';
 
 	const dispatch = createEventDispatcher();
-
+	let nameEl;
+	let valueEl;
 	const { id } = $page.params;
 	async function removeSecret() {
 		try {
@@ -25,6 +26,15 @@
 		}
 	}
 	async function saveSecret() {
+		const nameValid = nameEl.checkValidity();
+		const valueValid = valueEl.checkValidity();
+		if (!nameValid) {
+			return nameEl.reportValidity();
+		}
+		if (!valueValid) {
+			return valueEl.reportValidity();
+		}
+
 		try {
 			await post(`/applications/${id}/secrets.json`, { name, value, isBuildSecret });
 			dispatch('refresh');
@@ -47,7 +57,9 @@
 <td class="whitespace-nowrap px-6 py-2 text-sm font-medium text-white">
 	<input
 		id="secretName"
+		bind:this={nameEl}
 		bind:value={name}
+		required
 		placeholder="EXAMPLE_VARIABLE"
 		class="-mx-2 w-64 border-2 border-transparent"
 		readonly={!isNewSecret}
@@ -59,6 +71,8 @@
 	<input
 		id="secretValue"
 		bind:value
+		bind:this={valueEl}
+		required
 		placeholder="J$#@UIO%HO#$U%H"
 		class="-mx-2 w-64 border-2 border-transparent"
 		class:bg-transparent={!isNewSecret}