diff --git a/app/Http/Middleware/CanCreateResources.php b/app/Http/Middleware/CanCreateResources.php new file mode 100644 index 000000000..e91118ab0 --- /dev/null +++ b/app/Http/Middleware/CanCreateResources.php @@ -0,0 +1,25 @@ +isAdmin() && $user->teams()->get()->firstWhere('id', $application->team()->first()->id) !== null; } + + /** + * Determine whether the user can cleanup deployment queue. + */ + public function cleanupDeploymentQueue(User $user): bool + { + return $user->isAdmin(); + } } diff --git a/app/Policies/EnvironmentPolicy.php b/app/Policies/EnvironmentPolicy.php new file mode 100644 index 000000000..9fdcb3abe --- /dev/null +++ b/app/Policies/EnvironmentPolicy.php @@ -0,0 +1,65 @@ +teams()->get()->firstWhere('id', $environment->project->team_id) !== null; + } + + /** + * Determine whether the user can create models. + */ + public function create(User $user): bool + { + return $user->isAdmin(); + } + + /** + * Determine whether the user can update the model. + */ + public function update(User $user, Environment $environment): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $environment->project->team_id) !== null; + } + + /** + * Determine whether the user can delete the model. + */ + public function delete(User $user, Environment $environment): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $environment->project->team_id) !== null; + } + + /** + * Determine whether the user can restore the model. + */ + public function restore(User $user, Environment $environment): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $environment->project->team_id) !== null; + } + + /** + * Determine whether the user can permanently delete the model. + */ + public function forceDelete(User $user, Environment $environment): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $environment->project->team_id) !== null; + } +} diff --git a/app/Policies/ProjectPolicy.php b/app/Policies/ProjectPolicy.php new file mode 100644 index 000000000..27ed159bd --- /dev/null +++ b/app/Policies/ProjectPolicy.php @@ -0,0 +1,65 @@ +teams()->get()->firstWhere('id', $project->team_id) !== null; + } + + /** + * Determine whether the user can create models. + */ + public function create(User $user): bool + { + return $user->isAdmin(); + } + + /** + * Determine whether the user can update the model. + */ + public function update(User $user, Project $project): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $project->team_id) !== null; + } + + /** + * Determine whether the user can delete the model. + */ + public function delete(User $user, Project $project): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $project->team_id) !== null; + } + + /** + * Determine whether the user can restore the model. + */ + public function restore(User $user, Project $project): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $project->team_id) !== null; + } + + /** + * Determine whether the user can permanently delete the model. + */ + public function forceDelete(User $user, Project $project): bool + { + return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $project->team_id) !== null; + } +} diff --git a/app/Policies/ResourceCreatePolicy.php b/app/Policies/ResourceCreatePolicy.php new file mode 100644 index 000000000..58f6ba212 --- /dev/null +++ b/app/Policies/ResourceCreatePolicy.php @@ -0,0 +1,62 @@ +isAdmin(); + } + + /** + * Determine whether the user can create a specific resource type. + */ + public function create(User $user, string $resourceClass): bool + { + if (! in_array($resourceClass, self::CREATABLE_RESOURCES)) { + return false; + } + + return $user->isAdmin(); + } + + /** + * Authorize creation of all supported resource types. + */ + public function authorizeAllResourceCreation(User $user): bool + { + return $this->createAny($user); + } +} diff --git a/app/Policies/ServicePolicy.php b/app/Policies/ServicePolicy.php index b252d3600..c3f1f9a9a 100644 --- a/app/Policies/ServicePolicy.php +++ b/app/Policies/ServicePolicy.php @@ -28,7 +28,7 @@ class ServicePolicy */ public function create(User $user): bool { - return $user->isAdmin() && $user->teams()->get()->firstWhere('id', $service->team()->first()->id) !== null; + return $user->isAdmin(); } /** diff --git a/app/Providers/AuthServiceProvider.php b/app/Providers/AuthServiceProvider.php index 3aefca9f2..50d21b724 100644 --- a/app/Providers/AuthServiceProvider.php +++ b/app/Providers/AuthServiceProvider.php @@ -3,7 +3,9 @@ namespace App\Providers; // use Illuminate\Support\Facades\Gate; +use App\Policies\ResourceCreatePolicy; use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider; +use Illuminate\Support\Facades\Gate; class AuthServiceProvider extends ServiceProvider { @@ -20,6 +22,9 @@ class AuthServiceProvider extends ServiceProvider \App\Models\Application::class => \App\Policies\ApplicationPolicy::class, \App\Models\ApplicationPreview::class => \App\Policies\ApplicationPreviewPolicy::class, \App\Models\ApplicationSetting::class => \App\Policies\ApplicationSettingPolicy::class, + \App\Models\Service::class => \App\Policies\ServicePolicy::class, + \App\Models\Project::class => \App\Policies\ProjectPolicy::class, + \App\Models\Environment::class => \App\Policies\EnvironmentPolicy::class, // Database policies - all use the shared DatabasePolicy \App\Models\StandalonePostgresql::class => \App\Policies\DatabasePolicy::class, \App\Models\StandaloneMysql::class => \App\Policies\DatabasePolicy::class, @@ -29,6 +34,7 @@ class AuthServiceProvider extends ServiceProvider \App\Models\StandaloneKeydb::class => \App\Policies\DatabasePolicy::class, \App\Models\StandaloneDragonfly::class => \App\Policies\DatabasePolicy::class, \App\Models\StandaloneClickhouse::class => \App\Policies\DatabasePolicy::class, + ]; /** @@ -36,6 +42,7 @@ class AuthServiceProvider extends ServiceProvider */ public function boot(): void { - // + // Register gates for resource creation policy + Gate::define('createAnyResource', [ResourceCreatePolicy::class, 'createAny']); } } diff --git a/app/Traits/AuthorizesResourceCreation.php b/app/Traits/AuthorizesResourceCreation.php new file mode 100644 index 000000000..01ae7c8d9 --- /dev/null +++ b/app/Traits/AuthorizesResourceCreation.php @@ -0,0 +1,20 @@ +authorize('createAnyResource'); + } +} diff --git a/routes/web.php b/routes/web.php index d6e60653c..a8486defa 100644 --- a/routes/web.php +++ b/routes/web.php @@ -179,8 +179,8 @@ Route::middleware(['auth', 'verified'])->group(function () { }); Route::prefix('project/{project_uuid}/environment/{environment_uuid}')->group(function () { Route::get('/', ResourceIndex::class)->name('project.resource.index'); - Route::get('/clone', ProjectCloneMe::class)->name('project.clone-me'); - Route::get('/new', ResourceCreate::class)->name('project.resource.create'); + Route::get('/clone', ProjectCloneMe::class)->name('project.clone-me')->middleware('can.create.resources'); + Route::get('/new', ResourceCreate::class)->name('project.resource.create')->middleware('can.create.resources'); Route::get('/edit', EnvironmentEdit::class)->name('project.environment.edit'); }); Route::prefix('project/{project_uuid}/environment/{environment_uuid}/application/{application_uuid}')->group(function () {