dave/coolify
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #4990 from esarbanis/cron-validation-on-update

Browse Source 
fix: validate cron expression in Scheduled Task update
This commit is contained in:
Andras Bacsai
2025-01-28 11:00:53 +01:00
committed by GitHub
parent f283e9f53c 01b9cbdfea
commit 497a7ac15a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Livewire/Project/Shared/ScheduledTask/Show.php
View File

@@ -77,6 +77,10 @@ class Show extends Component
{ {
if ($toModel) { if ($toModel) {
$this->validate(); $this->validate();
$isValid = validate_cron_expression($this->frequency);
if (! $isValid) {
throw new \Exception('Invalid Cron / Human expression.');
}
$this->task->enabled = $this->isEnabled; $this->task->enabled = $this->isEnabled;
$this->task->name = str($this->name)->trim()->value(); $this->task->name = str($this->name)->trim()->value();
$this->task->command = str($this->command)->trim()->value(); $this->task->command = str($this->command)->trim()->value();
@@ -109,7 +113,7 @@ class Show extends Component
$this->syncData(true); $this->syncData(true);
$this->dispatch('success', 'Scheduled task updated.'); $this->dispatch('success', 'Scheduled task updated.');
} catch (\Exception $e) { } catch (\Exception $e) {
return handleError($e); return handleError($e, $this);
} }
} }