refactor(previews): move preview domain generation logic to ApplicationPreview model for better encapsulation and consistency across webhook handlers
This commit is contained in:
		@@ -143,12 +143,13 @@ class Bitbucket extends Controller
 | 
			
		||||
                                ]);
 | 
			
		||||
                                $pr_app->generate_preview_fqdn_compose();
 | 
			
		||||
                            } else {
 | 
			
		||||
                                ApplicationPreview::create([
 | 
			
		||||
                                $pr_app = ApplicationPreview::create([
 | 
			
		||||
                                    'git_type' => 'bitbucket',
 | 
			
		||||
                                    'application_id' => $application->id,
 | 
			
		||||
                                    'pull_request_id' => $pull_request_id,
 | 
			
		||||
                                    'pull_request_html_url' => $pull_request_html_url,
 | 
			
		||||
                                ]);
 | 
			
		||||
                                $pr_app->generate_preview_fqdn();
 | 
			
		||||
                            }
 | 
			
		||||
                        }
 | 
			
		||||
                        $result = queue_application_deployment(
 | 
			
		||||
 
 | 
			
		||||
@@ -175,12 +175,13 @@ class Gitea extends Controller
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn_compose();
 | 
			
		||||
                                } else {
 | 
			
		||||
                                    ApplicationPreview::create([
 | 
			
		||||
                                    $pr_app = ApplicationPreview::create([
 | 
			
		||||
                                        'git_type' => 'gitea',
 | 
			
		||||
                                        'application_id' => $application->id,
 | 
			
		||||
                                        'pull_request_id' => $pull_request_id,
 | 
			
		||||
                                        'pull_request_html_url' => $pull_request_html_url,
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn();
 | 
			
		||||
                                }
 | 
			
		||||
                            }
 | 
			
		||||
                            $result = queue_application_deployment(
 | 
			
		||||
 
 | 
			
		||||
@@ -183,12 +183,13 @@ class Github extends Controller
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn_compose();
 | 
			
		||||
                                } else {
 | 
			
		||||
                                    ApplicationPreview::create([
 | 
			
		||||
                                    $pr_app = ApplicationPreview::create([
 | 
			
		||||
                                        'git_type' => 'github',
 | 
			
		||||
                                        'application_id' => $application->id,
 | 
			
		||||
                                        'pull_request_id' => $pull_request_id,
 | 
			
		||||
                                        'pull_request_html_url' => $pull_request_html_url,
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn();
 | 
			
		||||
                                }
 | 
			
		||||
                            }
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -202,12 +202,13 @@ class Gitlab extends Controller
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn_compose();
 | 
			
		||||
                                } else {
 | 
			
		||||
                                    ApplicationPreview::create([
 | 
			
		||||
                                    $pr_app = ApplicationPreview::create([
 | 
			
		||||
                                        'git_type' => 'gitlab',
 | 
			
		||||
                                        'application_id' => $application->id,
 | 
			
		||||
                                        'pull_request_id' => $pull_request_id,
 | 
			
		||||
                                        'pull_request_html_url' => $pull_request_html_url,
 | 
			
		||||
                                    ]);
 | 
			
		||||
                                    $pr_app->generate_preview_fqdn();
 | 
			
		||||
                                }
 | 
			
		||||
                            }
 | 
			
		||||
                            $result = queue_application_deployment(
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user