From 6333d3fd13d999f19f36d8c2c7be9a62d9f557a2 Mon Sep 17 00:00:00 2001 From: Andras Bacsai Date: Tue, 2 Apr 2024 15:40:25 +0200 Subject: [PATCH] Fix image environment variable bug --- app/Jobs/ApplicationDeploymentJob.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.php index 0c6b6eecb..b30a49585 100644 --- a/app/Jobs/ApplicationDeploymentJob.php +++ b/app/Jobs/ApplicationDeploymentJob.php @@ -325,6 +325,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted executeInDocker($this->deployment_uuid, "echo '$dockerfile_base64' | base64 -d > {$this->workdir}{$this->dockerfile_location}") ], ); + // TODO: If the image exists and envs are changed, they are not applied. $this->generate_image_names(); if (!$this->force_rebuild) { $this->check_image_locally_or_remotely(); @@ -1373,6 +1374,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted $environment_variables = collect(); if ($this->pull_request_id === 0) { foreach ($this->application->runtime_environment_variables as $env) { + ray($env); // This is necessary because we have to escape the value of the environment variable // but only if the environment variable is created after 4.0.0-beta.240 // when I implemented the escaping feature.