From 64dd648b3fff3a709c4f82d40b71cc4106ad9984 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Sat, 14 Jun 2025 13:00:16 +0200 Subject: [PATCH] fix(terminal): now it should work --- .../Shared/ExecuteContainerCommand.php | 11 ---------- .../execute-container-command.blade.php | 21 ++----------------- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/app/Livewire/Project/Shared/ExecuteContainerCommand.php b/app/Livewire/Project/Shared/ExecuteContainerCommand.php index 2c16c1cfa..13fffea7e 100644 --- a/app/Livewire/Project/Shared/ExecuteContainerCommand.php +++ b/app/Livewire/Project/Shared/ExecuteContainerCommand.php @@ -27,8 +27,6 @@ class ExecuteContainerCommand extends Component public Collection $servers; - public bool $hasShell = true; - public bool $containersLoaded = false; public bool $autoConnectAttempted = false; @@ -250,7 +248,6 @@ class ExecuteContainerCommand extends Component if (! $this->server->isTerminalEnabled()) { throw new \RuntimeException('Terminal access is disabled on this server.'); } - $this->hasShell = true; $this->isConnecting = true; $this->connectionStatus = 'Establishing connection to server terminal...'; $this->dispatch( @@ -309,14 +306,6 @@ class ExecuteContainerCommand extends Component throw new \RuntimeException('Server ownership verification failed.'); } - $this->hasShell = $this->checkShellAvailability($server, data_get($container, 'container.Names')); - if (! $this->hasShell) { - $this->isConnecting = false; - $this->connectionStatus = 'Shell not available in container.'; - - return; - } - $this->isConnecting = true; $this->connectionStatus = 'Establishing connection to container terminal...'; $this->dispatch( diff --git a/resources/views/livewire/project/shared/execute-container-command.blade.php b/resources/views/livewire/project/shared/execute-container-command.blade.php index f34a62bd4..9b81b4647 100644 --- a/resources/views/livewire/project/shared/execute-container-command.blade.php +++ b/resources/views/livewire/project/shared/execute-container-command.blade.php @@ -17,25 +17,8 @@ @endif - @if (!$hasShell) -
-
-
- - - -
-

Terminal Not Available

-

No shell (bash/sh) is available in this container. Please - ensure either bash or sh is installed to use the terminal.

-
-
-
-
- @endif @if ($type === 'server') - @if ($server->isTerminalEnabled()) + @if (!$server->isForceDisabled() && $server->isTerminalEnabled())

Terminal

@@ -93,7 +76,7 @@ @endif @endif
- +
@endif @endif