From 6c78580f1fdb8dc7d758e45557dd825459a72d4d Mon Sep 17 00:00:00 2001 From: Andras Bacsai Date: Fri, 27 Sep 2024 15:27:05 +0200 Subject: [PATCH] refactor: Improve start proxy script to handle existing containers gracefully --- app/Actions/Proxy/StartProxy.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/Actions/Proxy/StartProxy.php b/app/Actions/Proxy/StartProxy.php index f025e5661..8cb3c644e 100644 --- a/app/Actions/Proxy/StartProxy.php +++ b/app/Actions/Proxy/StartProxy.php @@ -46,9 +46,11 @@ class StartProxy "echo 'Creating required Docker Compose file.'", "echo 'Pulling docker image.'", 'docker compose pull', - "echo 'Stopping existing coolify-proxy.'", - 'docker stop -t 10 coolify-proxy || true', - 'docker rm coolify-proxy || true', + 'if docker ps -a --format "{{.Names}}" | grep -q "^coolify-proxy$"; then', + " echo 'Stopping and removing existing coolify-proxy.'", + ' docker rm -f coolify-proxy || true', + " echo 'Successfully stopped and removed existing coolify-proxy.'", + 'fi', "echo 'Starting coolify-proxy.'", 'docker compose up -d --remove-orphans', "echo 'Proxy started successfully.'",