fix: use latest image if nothing is specified
This commit is contained in:
		@@ -333,7 +333,11 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
 | 
				
			|||||||
    private function deploy_dockerimage_buildpack()
 | 
					    private function deploy_dockerimage_buildpack()
 | 
				
			||||||
    {
 | 
					    {
 | 
				
			||||||
        $this->dockerImage = $this->application->docker_registry_image_name;
 | 
					        $this->dockerImage = $this->application->docker_registry_image_name;
 | 
				
			||||||
 | 
					        if (str($this->application->docker_registry_image_tag)->isEmpty()) {
 | 
				
			||||||
 | 
					            $this->dockerImageTag = 'latest';
 | 
				
			||||||
 | 
					        } else {
 | 
				
			||||||
            $this->dockerImageTag = $this->application->docker_registry_image_tag;
 | 
					            $this->dockerImageTag = $this->application->docker_registry_image_tag;
 | 
				
			||||||
 | 
					        }
 | 
				
			||||||
        ray("echo 'Starting deployment of {$this->dockerImage}:{$this->dockerImageTag} to {$this->server->name}.'");
 | 
					        ray("echo 'Starting deployment of {$this->dockerImage}:{$this->dockerImageTag} to {$this->server->name}.'");
 | 
				
			||||||
        $this->application_deployment_queue->addLogEntry("Starting deployment of {$this->dockerImage}:{$this->dockerImageTag} to {$this->server->name}.");
 | 
					        $this->application_deployment_queue->addLogEntry("Starting deployment of {$this->dockerImage}:{$this->dockerImageTag} to {$this->server->name}.");
 | 
				
			||||||
        $this->generate_image_names();
 | 
					        $this->generate_image_names();
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -232,7 +232,6 @@ class General extends Component
 | 
				
			|||||||
            if (data_get($this->application, 'build_pack') === 'dockerimage') {
 | 
					            if (data_get($this->application, 'build_pack') === 'dockerimage') {
 | 
				
			||||||
                $this->validate([
 | 
					                $this->validate([
 | 
				
			||||||
                    'application.docker_registry_image_name' => 'required',
 | 
					                    'application.docker_registry_image_name' => 'required',
 | 
				
			||||||
                    'application.docker_registry_image_tag' => 'required',
 | 
					 | 
				
			||||||
                ]);
 | 
					                ]);
 | 
				
			||||||
            }
 | 
					            }
 | 
				
			||||||
            if (data_get($this->application, 'fqdn')) {
 | 
					            if (data_get($this->application, 'fqdn')) {
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user