From 737f70387ca0d7bf08637ea66095c575a3c71384 Mon Sep 17 00:00:00 2001 From: peaklabs-dev <122374094+peaklabs-dev@users.noreply.github.com> Date: Wed, 11 Dec 2024 17:27:36 +0100 Subject: [PATCH] fix: seeder - do not hardcode IDs as this is bad practice. - Use update or create to allow the seeder to be run multiple times. --- database/seeders/OauthSettingSeeder.php | 38 +++++++++---------------- 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/database/seeders/OauthSettingSeeder.php b/database/seeders/OauthSettingSeeder.php index d0365c542..2b733120c 100644 --- a/database/seeders/OauthSettingSeeder.php +++ b/database/seeders/OauthSettingSeeder.php @@ -12,29 +12,19 @@ class OauthSettingSeeder extends Seeder */ public function run(): void { - OauthSetting::firstOrCreate([ - 'id' => 0, - 'provider' => 'azure', - ]); - OauthSetting::firstOrCreate([ - 'id' => 1, - 'provider' => 'bitbucket', - ]); - OauthSetting::firstOrCreate([ - 'id' => 2, - 'provider' => 'github', - ]); - OauthSetting::firstOrCreate([ - 'id' => 3, - 'provider' => 'gitlab', - ]); - OauthSetting::firstOrCreate([ - 'id' => 4, - 'provider' => 'google', - ]); - OauthSetting::firstOrCreate([ - 'id' => 5, - 'provider' => 'authentik', - ]); + $providers = [ + 'azure', + 'bitbucket', + 'github', + 'gitlab', + 'google', + 'authentik', + ]; + + foreach ($providers as $provider) { + OauthSetting::updateOrCreate( + ['provider' => $provider] + ); + } } }