fix(email notifications): enhance EmailChannel to validate team membership for recipients and handle errors gracefully

app/Notifications/Channels/EmailChannel.php

@@ -2,6 +2,8 @@
 
 namespace App\Notifications\Channels;
 
+use App\Models\Team;
+use Exception;
 use Illuminate\Notifications\Notification;
 use Resend;
 
@@ -11,21 +13,53 @@ class EmailChannel
 
     public function send(SendsEmail $notifiable, Notification $notification): void
     {
+        try {
+            // Get team and validate membership before proceeding
+            $team = data_get($notifiable, 'id');
+            $members = Team::find($team)->members;
+
             $useInstanceEmailSettings = $notifiable->emailNotificationSettings->use_instance_email_settings;
             $isTransactionalEmail = data_get($notification, 'isTransactionalEmail', false);
             $customEmails = data_get($notification, 'emails', null);
+
             if ($useInstanceEmailSettings || $isTransactionalEmail) {
                 $settings = instanceSettings();
             } else {
                 $settings = $notifiable->emailNotificationSettings;
             }
+
             $isResendEnabled = $settings->resend_enabled;
             $isSmtpEnabled = $settings->smtp_enabled;
+
             if ($customEmails) {
                 $recipients = [$customEmails];
             } else {
                 $recipients = $notifiable->getRecipients();
             }
+
+            // Validate team membership for all recipients
+            if (count($recipients) === 0) {
+                throw new Exception('No email recipients found');
+            }
+
+            foreach ($recipients as $recipient) {
+                // Check if the recipient is part of the team
+                if (! $members->contains('email', $recipient)) {
+                    $emailSettings = $notifiable->emailNotificationSettings;
+                    data_set($emailSettings, 'smtp_password', '********');
+                    data_set($emailSettings, 'resend_api_key', '********');
+                    send_internal_notification(sprintf(
+                        "Recipient is not part of the team: %s\nTeam: %s\nNotification: %s\nNotifiable: %s\nEmail Settings:\n%s",
+                        $recipient,
+                        $team,
+                        get_class($notification),
+                        get_class($notifiable),
+                        json_encode($emailSettings, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)
+                    ));
+                    throw new Exception('Recipient is not part of the team');
+                }
+            }
+
             $mailMessage = $notification->toMail($notifiable);
 
             if ($isResendEnabled) {
@@ -66,5 +100,15 @@ class EmailChannel
 
                 $mailer->send($email);
             }
+        } catch (\Throwable $e) {
+            \Illuminate\Support\Facades\Log::error('EmailChannel failed: '.$e->getMessage(), [
+                'notification' => get_class($notification),
+                'notifiable' => get_class($notifiable),
+                'team_id' => data_get($notifiable, 'id'),
+                'error' => $e->getMessage(),
+                'trace' => $e->getTraceAsString(),
+            ]);
+            throw $e;
+        }
     }
 }