diff --git a/bootstrap/helpers/docker.php b/bootstrap/helpers/docker.php index d094b0f57..03c4b3376 100644 --- a/bootstrap/helpers/docker.php +++ b/bootstrap/helpers/docker.php @@ -582,7 +582,6 @@ function generateLabelsApplication(Application $application, ?ApplicationPreview if ($pull_request_id !== 0) { $appUuid = $appUuid.'-pr-'.$pull_request_id; } - ray($application); $labels = collect([]); if ($pull_request_id === 0) { if ($application->fqdn) { @@ -749,7 +748,6 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null) '--ulimit', '--device', '--shm-size', - '--hostname', ]); $mapping = collect([ '--cap-add' => 'cap_add', @@ -763,7 +761,7 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null) '--ip' => 'ip', '--shm-size' => 'shm_size', '--gpus' => 'gpus', - '--hostname' => 'hostname' + '--hostname' => 'hostname', ]); foreach ($matches as $match) { $option = $match[1]; @@ -810,7 +808,7 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null) } }); $compose_options->put($mapping[$option], $ulimits); - } elseif ($option === '--shm-size') { + } elseif ($option === '--shm-size' || $option === '--hostname') { if (! is_null($value) && is_array($value) && count($value) > 0) { $compose_options->put($mapping[$option], $value[0]); } @@ -849,7 +847,6 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null) continue; } - $compose_options->forget($option); } } diff --git a/tests/Feature/DockerCustomCommandsTest.php b/tests/Feature/DockerCustomCommandsTest.php index a07372069..e2e2cee05 100644 --- a/tests/Feature/DockerCustomCommandsTest.php +++ b/tests/Feature/DockerCustomCommandsTest.php @@ -1,10 +1,11 @@ toBe([ 'cap_add' => ['NET_ADMIN', 'NET_RAW', 'SYS_ADMIN'], + 'hostname' => 'test', ]); });