fix(parsers): clarify comments and update variable checks for FQDN and URL handling

This commit is contained in:
Andras Bacsai
2025-08-08 18:56:29 +02:00
parent c3a100730c
commit 936a192236

View File

@@ -990,7 +990,7 @@ function serviceParser(Service $resource): Collection
} }
} }
} }
// Get magic environments where we need to preset the FQDN // Get magic environments where we need to preset the FQDN / URL
if ($key->startsWith('SERVICE_FQDN_') || $key->startsWith('SERVICE_URL_')) { if ($key->startsWith('SERVICE_FQDN_') || $key->startsWith('SERVICE_URL_')) {
// SERVICE_FQDN_APP or SERVICE_FQDN_APP_3000 // SERVICE_FQDN_APP or SERVICE_FQDN_APP_3000
if (substr_count(str($key)->value(), '_') === 3) { if (substr_count(str($key)->value(), '_') === 3) {
@@ -1457,7 +1457,7 @@ function serviceParser(Service $resource): Collection
$value = str($value); $value = str($value);
$originalValue = $value; $originalValue = $value;
$parsedValue = replaceVariables($value); $parsedValue = replaceVariables($value);
if ($value->startsWith('$SERVICE_')) { if ($parsedValue->startsWith('SERVICE_')) {
$resource->environment_variables()->firstOrCreate([ $resource->environment_variables()->firstOrCreate([
'key' => $key, 'key' => $key,
'resourceable_type' => get_class($resource), 'resourceable_type' => get_class($resource),