From 9e8d9e6a9ea55ca24991862095d13eda3c11adf5 Mon Sep 17 00:00:00 2001
From: SierraJC <7351311+SierraJC@users.noreply.github.com>
Date: Sat, 14 Dec 2024 12:52:47 +1100
Subject: [PATCH] fix: invalid API response on missing project

API was returning 500 instead of 404 due to attempting to load environments for a non-existent project
---
 app/Http/Controllers/Api/ProjectController.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/Http/Controllers/Api/ProjectController.php b/app/Http/Controllers/Api/ProjectController.php
index 1d89c82ed..e7b0af785 100644
--- a/app/Http/Controllers/Api/ProjectController.php
+++ b/app/Http/Controllers/Api/ProjectController.php
@@ -90,11 +90,12 @@ class ProjectController extends Controller
         if (is_null($teamId)) {
             return invalidTokenResponse();
         }
-        $project = Project::whereTeamId($teamId)->whereUuid(request()->uuid)->first()->load(['environments']);
+        $project = Project::whereTeamId($teamId)->whereUuid(request()->uuid)->first();
         if (! $project) {
             return response()->json(['message' => 'Project not found.'], 404);
         }
 
+        $project->load(['environments']);
         return response()->json(
             serializeApiResponse($project),
         );