fix(webhook): replace delete with forceDelete for application previews to ensure immediate removal

This commit is contained in:
Andras Bacsai
2025-09-05 17:50:33 +02:00
parent 28d05f759e
commit a10e51b2c4

View File

@@ -240,7 +240,7 @@ class Github extends Controller
if ($action === 'closed') { if ($action === 'closed') {
$found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first(); $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
if ($found) { if ($found) {
$found->delete(); $found->forceDelete();
$container_name = generateApplicationContainerName($application, $pull_request_id); $container_name = generateApplicationContainerName($application, $pull_request_id);
instant_remote_process(["docker rm -f $container_name"], $application->destination->server); instant_remote_process(["docker rm -f $container_name"], $application->destination->server);
$return_payloads->push([ $return_payloads->push([
@@ -480,7 +480,7 @@ class Github extends Controller
} }
ApplicationPullRequestUpdateJob::dispatchSync(application: $application, preview: $found, status: ProcessStatus::CLOSED); ApplicationPullRequestUpdateJob::dispatchSync(application: $application, preview: $found, status: ProcessStatus::CLOSED);
$found->delete(); $found->forceDelete();
$return_payloads->push([ $return_payloads->push([
'application' => $application->name, 'application' => $application->name,