dave/coolify
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3947 from peaklabs-dev/fix-is-required

Browse Source 
Fix: Required environment variable throws and errors when updating shared variables
This commit is contained in:
Andras Bacsai
2024-10-22 11:15:26 +02:00
committed by GitHub
parent d9a9205e49 1d2e9b6946
commit bfd6923ba6
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Livewire/Project/Shared/EnvironmentVariable/Show.php
View File

@@ -112,14 +112,20 @@ class Show extends Component
$this->validate(); $this->validate();
} }
if ($this->env->is_required && str($this->env->real_value)->isEmpty()) { if (! $this->isSharedVariable && $this->env->is_required && str($this->env->real_value)->isEmpty()) {
$oldValue = $this->env->getOriginal('value'); $oldValue = $this->env->getOriginal('value');
$this->env->value = $oldValue; $this->env->value = $oldValue;
$this->dispatch('error', 'Required environment variable cannot be empty.'); $this->dispatch('error', 'Required environment variable cannot be empty.');
return; return;
} }
$this->serialize(); $this->serialize();
if ($this->isSharedVariable) {
unset($this->env->is_required);
}
$this->env->save(); $this->env->save();
$this->dispatch('success', 'Environment variable updated.'); $this->dispatch('success', 'Environment variable updated.');
$this->dispatch('envsUpdated'); $this->dispatch('envsUpdated');