dave/coolify
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: remove more logging

Browse Source
This commit is contained in:
peaklabs-dev
2025-01-06 21:16:57 +01:00
parent 09dfbde676
commit c789ed6003
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Jobs/GithubAppPermissionJob.php
View File

@@ -10,7 +10,6 @@ use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue; use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels; use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Facades\Http; use Illuminate\Support\Facades\Http;
use Illuminate\Support\Facades\Log;
class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue
{ {
@@ -36,11 +35,6 @@ class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue
])->get("{$this->github_app->api_url}/app"); ])->get("{$this->github_app->api_url}/app");
if (! $response->successful()) { if (! $response->successful()) {
Log::error('GitHub API request failed', [
'status_code' => $response->status(),
'error' => $response->body(),
'app_id' => $this->github_app->app_id,
]);
throw new \RuntimeException('Failed to fetch GitHub app permissions: '.$response->body()); throw new \RuntimeException('Failed to fetch GitHub app permissions: '.$response->body());
} }
@@ -56,12 +50,6 @@ class GithubAppPermissionJob implements ShouldBeEncrypted, ShouldQueue
$this->github_app->makeVisible('client_secret')->makeVisible('webhook_secret'); $this->github_app->makeVisible('client_secret')->makeVisible('webhook_secret');
} catch (\Throwable $e) { } catch (\Throwable $e) {
Log::error('GithubAppPermissionJob failed', [
'app_id' => $this->github_app->app_id,
'error' => $e->getMessage(),
'trace' => $e->getTraceAsString(),
]);
send_internal_notification('GithubAppPermissionJob failed with: '.$e->getMessage()); send_internal_notification('GithubAppPermissionJob failed with: '.$e->getMessage());
throw $e; throw $e;
} }

11
bootstrap/helpers/github.php
View File

@@ -5,7 +5,6 @@ use App\Models\GitlabApp;
use Carbon\Carbon; use Carbon\Carbon;
use Carbon\CarbonImmutable; use Carbon\CarbonImmutable;
use Illuminate\Support\Facades\Http; use Illuminate\Support\Facades\Http;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Str; use Illuminate\Support\Str;
use Lcobucci\JWT\Encoding\ChainedFormatter; use Lcobucci\JWT\Encoding\ChainedFormatter;
use Lcobucci\JWT\Encoding\JoseEncoder; use Lcobucci\JWT\Encoding\JoseEncoder;
@@ -21,11 +20,6 @@ function generateGithubToken(GithubApp $source, string $type)
$timeDiff = abs($serverTime->diffInSeconds($githubTime)); $timeDiff = abs($serverTime->diffInSeconds($githubTime));
if ($timeDiff > 50) { if ($timeDiff > 50) {
Log::error('System time out of sync with GitHub', [
'time_difference' => $timeDiff,
'server_time' => $serverTime->format('Y-m-d H:i:s'),
'github_time' => $githubTime->format('Y-m-d H:i:s'),
]);
throw new \Exception( throw new \Exception(
'System time is out of sync with GitHub API time:<br>'. 'System time is out of sync with GitHub API time:<br>'.
'- System time: '.$serverTime->format('Y-m-d H:i:s').' UTC<br>'. '- System time: '.$serverTime->format('Y-m-d H:i:s').' UTC<br>'.
@@ -58,11 +52,6 @@ function generateGithubToken(GithubApp $source, string $type)
if (! $response->successful()) { if (! $response->successful()) {
$error = data_get($response->json(), 'message', 'no error message found'); $error = data_get($response->json(), 'message', 'no error message found');
Log::error('Failed to get installation token', [
'status_code' => $response->status(),
'error_message' => $error,
'app_id' => $source->app_id,
]);
throw new RuntimeException("Failed to get installation token for {$source->name} with error: ".$error); throw new RuntimeException("Failed to get installation token for {$source->name} with error: ".$error);
} }