From cd335e9e00bf2ee71e7bf1f5c88e67d5569197e7 Mon Sep 17 00:00:00 2001 From: peaklabs-dev <122374094+peaklabs-dev@users.noreply.github.com> Date: Mon, 3 Feb 2025 22:42:15 +0100 Subject: [PATCH] fix(ssl): make sure the subjectAlternativeNames are unique and stored correctly --- app/Helpers/SslHelper.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/Helpers/SslHelper.php b/app/Helpers/SslHelper.php index 43df8114e..ffa2279e8 100644 --- a/app/Helpers/SslHelper.php +++ b/app/Helpers/SslHelper.php @@ -54,9 +54,12 @@ class SslHelper } } + $subjectAlternativeNames = array_unique( + array_merge(["DNS:$commonName"], $subjectAlternativeNames) + ); $certificateSubject = [ 'commonName' => $commonName, - 'subjectAltName' => implode(', ', array_merge(["DNS:$commonName"], $subjectAlternativeNames)), + 'subjectAltName' => $subjectAlternativeNames, 'organizationName' => self::DEFAULT_ORGANIZATION_NAME, 'countryName' => self::DEFAULT_COUNTRY_CODE, 'stateOrProvinceName' => self::DEFAULT_STATE,