From dc32bed1ae09f6e889442ac6ba435cb8da345778 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Tue, 23 Sep 2025 08:54:20 +0200 Subject: [PATCH] fix(environment-variables): update affected services in environment variable analysis - Expanded the list of affected services in the EnvironmentVariableAnalyzer trait to include 'bun' and 'pnpm' alongside 'npm' and 'yarn'. - Improved clarity on the impact of problematic environment variables during the build process. --- app/Traits/EnvironmentVariableAnalyzer.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Traits/EnvironmentVariableAnalyzer.php b/app/Traits/EnvironmentVariableAnalyzer.php index a2fe0eeba..c264e60b3 100644 --- a/app/Traits/EnvironmentVariableAnalyzer.php +++ b/app/Traits/EnvironmentVariableAnalyzer.php @@ -13,19 +13,19 @@ trait EnvironmentVariableAnalyzer return [ 'NODE_ENV' => [ 'problematic_values' => ['production', 'prod'], - 'affects' => 'Node.js/npm/yarn', + 'affects' => 'Node.js/npm/yarn/bun/pnpm', 'issue' => 'Skips devDependencies installation which are often required for building (webpack, typescript, etc.)', 'recommendation' => 'Uncheck "Available at Buildtime" or use "development" during build', ], 'NPM_CONFIG_PRODUCTION' => [ 'problematic_values' => ['true', '1', 'yes'], - 'affects' => 'npm', + 'affects' => 'npm/pnpm', 'issue' => 'Forces npm to skip devDependencies', 'recommendation' => 'Remove from build-time variables or set to false', ], 'YARN_PRODUCTION' => [ 'problematic_values' => ['true', '1', 'yes'], - 'affects' => 'Yarn', + 'affects' => 'Yarn/pnpm', 'issue' => 'Forces yarn to skip devDependencies', 'recommendation' => 'Remove from build-time variables or set to false', ],