From e67e03f73f2c8405b9bb96d6c1adb3f27c1b7e48 Mon Sep 17 00:00:00 2001
From: ayntk-ai <122374094+ayntk-ai@users.noreply.github.com>
Date: Fri, 9 Aug 2024 02:15:40 +0200
Subject: [PATCH] added comments and removed temp ones

---
 app/Actions/Service/DeleteService.php | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/app/Actions/Service/DeleteService.php b/app/Actions/Service/DeleteService.php
index 13b5cc50b..521a70e83 100644
--- a/app/Actions/Service/DeleteService.php
+++ b/app/Actions/Service/DeleteService.php
@@ -35,7 +35,7 @@ class DeleteService
                     $commands[] = "docker volume rm -f $storage->name";
                 }
 
-                // Execute all commands
+                // Execute volume deletion first, this must be done first otherwise volumes will not be deleted.
                 if (!empty($commands)) {
                     foreach ($commands as $command) {
                         $result = instant_remote_process([$command], $server, false);
@@ -46,22 +46,18 @@ class DeleteService
                 }
             }
 
-            // Delete networks if the flag is set
             if ($deleteConnectedNetworks) {
                 $uuid = $service->uuid;
                 $service->delete_connected_networks($uuid);
             }
 
-            // Command to remove the service itself
             $commands[] = "docker rm -f $service->uuid";
 
-            // Execute all commands
+            // Executing remaining commands
             instant_remote_process($commands, $server, false);
-            
         } catch (\Exception $e) {
             throw new \Exception($e->getMessage());
         } finally {
-            // Delete configurations if the flag is set
             if ($deleteConfigurations) {
                 $service->delete_configurations();
             }
@@ -77,10 +73,9 @@ class DeleteService
             $service->tags()->detach();
             $service->forceDelete();
 
-            // Run cleanup if images need to be deleted
             if ($deleteImages) {
                 CleanupDocker::run($server, true);
             }
         }
     }
-}
\ No newline at end of file
+}