From ea115e6d31e9943413829a12e6cd739358f29e0d Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Thu, 3 Jul 2025 15:52:26 +0200 Subject: [PATCH] refactor(policy): optimize team membership checks in S3StoragePolicy --- app/Policies/S3StoragePolicy.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Policies/S3StoragePolicy.php b/app/Policies/S3StoragePolicy.php index 9a8c435a3..28f5f8426 100644 --- a/app/Policies/S3StoragePolicy.php +++ b/app/Policies/S3StoragePolicy.php @@ -21,7 +21,7 @@ class S3StoragePolicy */ public function view(User $user, S3Storage $storage): bool { - return $user->teams()->get()->firstWhere('id', $storage->team_id) !== null; + return $user->teams()->where('id', $storage->team_id)->exists(); } /** @@ -45,7 +45,7 @@ class S3StoragePolicy */ public function delete(User $user, S3Storage $storage): bool { - return $user->teams()->get()->firstWhere('id', $storage->team_id) !== null; + return $user->teams()->where('id', $storage->team_id)->exists(); } /**