From ee5c0f0413a78843603de1e2db2cb3a00aabfe27 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Mon, 31 Mar 2025 17:33:01 +0200 Subject: [PATCH] fix(deploy): validate team ID before deployment --- app/Http/Controllers/Api/DeployController.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/Http/Controllers/Api/DeployController.php b/app/Http/Controllers/Api/DeployController.php index 2da517256..7772f15e2 100644 --- a/app/Http/Controllers/Api/DeployController.php +++ b/app/Http/Controllers/Api/DeployController.php @@ -185,6 +185,11 @@ class DeployController extends Controller public function deploy(Request $request) { $teamId = getTeamIdFromToken(); + + if (is_null($teamId)) { + return invalidTokenResponse(); + } + $uuids = $request->query->get('uuid'); $tags = $request->query->get('tag'); $force = $request->query->get('force') ?? false; @@ -193,9 +198,6 @@ class DeployController extends Controller if ($uuids && $tags) { return response()->json(['message' => 'You can only use uuid or tag, not both.'], 400); } - if (is_null($teamId)) { - return invalidTokenResponse(); - } if ($tags && $pr) { return response()->json(['message' => 'You can only use tag or pr, not both.'], 400); }