From 120308638fde049bbc0d23229fc08cd170715cca Mon Sep 17 00:00:00 2001 From: Daya Adianto Date: Sat, 25 Feb 2023 17:21:02 +0700 Subject: [PATCH] fix: set PACK_VERSION to 0.27.0 This commit removes the `v` prefix in the version identifier assigned to PACK_VERSION build argument. The `pack` script actually available on Coolify's CDN, but named without `v` prefix in the script's version identifier. Related issue: #689, which reported that the `pack` script in the container image is a HTML 404 file instead of the actual `pack` executable. --- Dockerfile | 4 ++-- Dockerfile-dev | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index 6638bb202..adcbee05b 100644 --- a/Dockerfile +++ b/Dockerfile @@ -22,7 +22,7 @@ ARG DOCKER_VERSION=20.10.18 # Reverted to 2.6.1 because of this https://github.com/docker/compose/issues/9704. 2.9.0 still has a bug. ARG DOCKER_COMPOSE_VERSION=2.6.1 # https://github.com/buildpacks/pack/releases -ARG PACK_VERSION=v0.27.0 +ARG PACK_VERSION=0.27.0 RUN apt update && apt -y install --no-install-recommends ca-certificates git git-lfs openssh-client curl jq cmake sqlite3 openssl psmisc python3 RUN apt-get clean autoclean && apt-get autoremove --yes && rm -rf /var/lib/{apt,dpkg,cache,log}/ @@ -50,4 +50,4 @@ RUN pnpm install -p EXPOSE 3000 ENV CHECKPOINT_DISABLE=1 -CMD pnpm start \ No newline at end of file +CMD pnpm start diff --git a/Dockerfile-dev b/Dockerfile-dev index 198307656..13b3a8560 100644 --- a/Dockerfile-dev +++ b/Dockerfile-dev @@ -9,7 +9,7 @@ ARG DOCKER_VERSION=20.10.18 # Reverted to 2.6.1 because of this https://github.com/docker/compose/issues/9704. 2.9.0 still has a bug. ARG DOCKER_COMPOSE_VERSION=2.6.1 # https://github.com/buildpacks/pack/releases -ARG PACK_VERSION=v0.27.0 +ARG PACK_VERSION=0.27.0 WORKDIR /app RUN npm --no-update-notifier --no-fund --global install pnpm@${PNPM_VERSION} @@ -28,4 +28,4 @@ RUN curl -SL https://cdn.coollabs.io/bin/$TARGETPLATFORM/pack-$PACK_VERSION -o / RUN chmod +x ~/.docker/cli-plugins/docker-compose /usr/bin/docker /usr/local/bin/pack EXPOSE 3000 -ENV CHECKPOINT_DISABLE=1 \ No newline at end of file +ENV CHECKPOINT_DISABLE=1