From fd9dae6e4b90692dbb97f13b6d8fedf20abf29cf Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@gmail.com>
Date: Tue, 2 Apr 2024 15:40:19 +0200
Subject: [PATCH] Refactor EnvironmentVariable creation logic

---
 app/Models/EnvironmentVariable.php | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/app/Models/EnvironmentVariable.php b/app/Models/EnvironmentVariable.php
index 611543b2d..32277769e 100644
--- a/app/Models/EnvironmentVariable.php
+++ b/app/Models/EnvironmentVariable.php
@@ -25,19 +25,18 @@ class EnvironmentVariable extends Model
         static::created(function (EnvironmentVariable $environment_variable) {
             if ($environment_variable->application_id && !$environment_variable->is_preview) {
                 $found = ModelsEnvironmentVariable::where('key', $environment_variable->key)->where('application_id', $environment_variable->application_id)->where('is_preview', true)->first();
-                $application = Application::find($environment_variable->application_id);
-                if ($application->build_pack === 'dockerfile') {
-                    return;
-                }
                 if (!$found) {
-                    ModelsEnvironmentVariable::create([
-                        'key' => $environment_variable->key,
-                        'value' => $environment_variable->value,
-                        'is_build_time' => $environment_variable->is_build_time,
-                        'is_multiline' => $environment_variable->is_multiline,
-                        'application_id' => $environment_variable->application_id,
-                        'is_preview' => true
-                    ]);
+                    $application = Application::find($environment_variable->application_id);
+                    if ($application->build_pack !== 'dockerfile') {
+                        ModelsEnvironmentVariable::create([
+                            'key' => $environment_variable->key,
+                            'value' => $environment_variable->value,
+                            'is_build_time' => $environment_variable->is_build_time,
+                            'is_multiline' => $environment_variable->is_multiline,
+                            'application_id' => $environment_variable->application_id,
+                            'is_preview' => true
+                        ]);
+                    }
                 }
             }
             $environment_variable->update([