dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Codechange: Warn if randomaction2 group count is not a power of 2.

Browse Source 
Previously noted by a comment, this does not need to be guarded against as non-powers of 2 will not cause issues beyond the choice of results being reduced.

(cherry picked from commit 18fb1c3866)
This commit is contained in:
Peter Nelson
2021-05-02 00:34:17 +01:00
committed by Jonathan G Rennison
parent 02a62e4c98
commit 0b4d45af93
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/newgrf.cpp
View File

@@ -5275,6 +5275,10 @@ static void NewSpriteGroup(ByteReader *buf)
group->lowest_randbit = buf->ReadByte(); group->lowest_randbit = buf->ReadByte();
byte num_groups = buf->ReadByte(); byte num_groups = buf->ReadByte();
if (!HasExactlyOneBit(num_groups)) {
grfmsg(1, "NewSpriteGroup: Random Action 2 nrand should be power of 2");
}
for (uint i = 0; i < num_groups; i++) { for (uint i = 0; i < num_groups; i++) {
group->groups.push_back(GetGroupFromGroupID(setid, type, buf->ReadWord())); group->groups.push_back(GetGroupFromGroupID(setid, type, buf->ReadWord()));
} }