dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Codechange: silence some potentially uninitialized local variable errors

Browse Source 
In these cases technically they are false positives, however dismissing the
alerts when the underlying code may make them true positives does not seem
like the safest solution.
This commit is contained in:
Rubidium
2023-01-03 19:02:36 +01:00
committed by rubidium42
parent 496ec1f012
commit 170f37d07f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/company_gui.cpp
View File

@@ -636,7 +636,7 @@ private:
const Company *c; const Company *c;
const Livery *livery, *default_livery = nullptr; const Livery *livery, *default_livery = nullptr;
bool primary = widget == WID_SCL_PRI_COL_DROPDOWN; bool primary = widget == WID_SCL_PRI_COL_DROPDOWN;
byte default_col; byte default_col = 0;
/* Disallow other company colours for the primary colour */ /* Disallow other company colours for the primary colour */
if (this->livery_class < LC_GROUP_RAIL && HasBit(this->sel, LS_DEFAULT) && primary) { if (this->livery_class < LC_GROUP_RAIL && HasBit(this->sel, LS_DEFAULT) && primary) {

2
src/script/api/script_rail.cpp
View File

@@ -449,7 +449,7 @@ static bool IsValidSignalType(int signal_type)
EnforcePrecondition(false, ::IsValidSignalType(signal)); EnforcePrecondition(false, ::IsValidSignalType(signal));
Track track = INVALID_TRACK; Track track = INVALID_TRACK;
uint signal_cycles; uint signal_cycles = 0;
int data_index = 2 + (::TileX(front) - ::TileX(tile)) + 2 * (::TileY(front) - ::TileY(tile)); int data_index = 2 + (::TileX(front) - ::TileX(tile)) + 2 * (::TileY(front) - ::TileY(tile));
for (int i = 0; i < NUM_TRACK_DIRECTIONS; i++) { for (int i = 0; i < NUM_TRACK_DIRECTIONS; i++) {