Codechange: do not make a string valid in place, to then copy it

2023-07-05 19:36:35 +02:00
parent b958a343fe
commit 18a31cca7c
3 changed files with 5 additions and 10 deletions
--- a/src/script/script_instance.cpp
+++ b/src/script/script_instance.cpp
@@ -573,8 +573,7 @@ bool ScriptInstance::IsPaused()
 			SlObject(nullptr, _script_byte);
 			static char buf[std::numeric_limits<decltype(_script_sl_byte)>::max()];
 			SlCopy(buf, _script_sl_byte, SLE_CHAR);
-			StrMakeValidInPlace(buf, buf + _script_sl_byte);
-			if (data != nullptr) data->push_back(std::string(buf));
+			if (data != nullptr) data->push_back(StrMakeValid(std::string_view(buf, _script_sl_byte)));
 			return true;
 		}