(svn r6295) -Feature: using goto depot with a different control selection will now alter the service/stopping in depot flag instead of cancelling the goto depot order
This commit is contained in:
		@@ -512,6 +512,17 @@ int32 CmdSendAircraftToHangar(TileIndex tile, uint32 flags, uint32 p1, uint32 p2
 | 
				
			|||||||
	if (v->type != VEH_Aircraft || !CheckOwnership(v->owner)) return CMD_ERROR;
 | 
						if (v->type != VEH_Aircraft || !CheckOwnership(v->owner)) return CMD_ERROR;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (v->current_order.type == OT_GOTO_DEPOT && !(p2 & DEPOT_LOCATE_HANGAR)) {
 | 
						if (v->current_order.type == OT_GOTO_DEPOT && !(p2 & DEPOT_LOCATE_HANGAR)) {
 | 
				
			||||||
 | 
							if ((p2 & DEPOT_SERVICE) == (bool)HASBIT(v->current_order.flags, OFB_HALT_IN_DEPOT)) {
 | 
				
			||||||
 | 
								/* We called with a different DEPOT_SERVICE setting.
 | 
				
			||||||
 | 
								 * Now we change the setting to apply the new one and let the vehicle head for the same hangar.
 | 
				
			||||||
 | 
								 * Note: the if is (true for requesting service == true for ordered to stop in hangar)          */
 | 
				
			||||||
 | 
								if (flags & DC_EXEC) {
 | 
				
			||||||
 | 
									TOGGLEBIT(v->current_order.flags, OFB_HALT_IN_DEPOT);
 | 
				
			||||||
 | 
									InvalidateWindowWidget(WC_VEHICLE_VIEW, v->index, STATUS_BAR);
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
 | 
								return 0;
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of hangar orders
 | 
							if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of hangar orders
 | 
				
			||||||
		if (flags & DC_EXEC) {
 | 
							if (flags & DC_EXEC) {
 | 
				
			||||||
			if (v->current_order.flags & OF_UNLOAD) v->cur_order_index++;
 | 
								if (v->current_order.flags & OF_UNLOAD) v->cur_order_index++;
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -382,6 +382,17 @@ int32 CmdSendRoadVehToDepot(TileIndex tile, uint32 flags, uint32 p1, uint32 p2)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	/* If the current orders are already goto-depot */
 | 
						/* If the current orders are already goto-depot */
 | 
				
			||||||
	if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
						if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
				
			||||||
 | 
							if ((p2 & DEPOT_SERVICE) == (bool)HASBIT(v->current_order.flags, OFB_HALT_IN_DEPOT)) {
 | 
				
			||||||
 | 
								/* We called with a different DEPOT_SERVICE setting.
 | 
				
			||||||
 | 
								* Now we change the setting to apply the new one and let the vehicle head for the same depot.
 | 
				
			||||||
 | 
								* Note: the if is (true for requesting service == true for ordered to stop in depot)          */
 | 
				
			||||||
 | 
								if (flags & DC_EXEC) {
 | 
				
			||||||
 | 
									TOGGLEBIT(v->current_order.flags, OFB_HALT_IN_DEPOT);
 | 
				
			||||||
 | 
									InvalidateWindowWidget(WC_VEHICLE_VIEW, v->index, STATUS_BAR);
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
 | 
								return 0;
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
							if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
				
			||||||
		if (flags & DC_EXEC) {
 | 
							if (flags & DC_EXEC) {
 | 
				
			||||||
			/* If the orders to 'goto depot' are in the orders list (forced servicing),
 | 
								/* If the orders to 'goto depot' are in the orders list (forced servicing),
 | 
				
			||||||
 
 | 
				
			|||||||
							
								
								
									
										11
									
								
								ship_cmd.c
									
									
									
									
									
								
							
							
						
						
									
										11
									
								
								ship_cmd.c
									
									
									
									
									
								
							@@ -1020,6 +1020,17 @@ int32 CmdSendShipToDepot(TileIndex tile, uint32 flags, uint32 p1, uint32 p2)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	/* If the current orders are already goto-depot */
 | 
						/* If the current orders are already goto-depot */
 | 
				
			||||||
	if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
						if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
				
			||||||
 | 
							if ((p2 & DEPOT_SERVICE) == (bool)HASBIT(v->current_order.flags, OFB_HALT_IN_DEPOT)) {
 | 
				
			||||||
 | 
								/* We called with a different DEPOT_SERVICE setting.
 | 
				
			||||||
 | 
								 * Now we change the setting to apply the new one and let the vehicle head for the same depot.
 | 
				
			||||||
 | 
								 * Note: the if is (true for requesting service == true for ordered to stop in depot)          */
 | 
				
			||||||
 | 
								if (flags & DC_EXEC) {
 | 
				
			||||||
 | 
									TOGGLEBIT(v->current_order.flags, OFB_HALT_IN_DEPOT);
 | 
				
			||||||
 | 
									InvalidateWindowWidget(WC_VEHICLE_VIEW, v->index, STATUS_BAR);
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
 | 
								return 0;
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
							if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
				
			||||||
		if (flags & DC_EXEC) {
 | 
							if (flags & DC_EXEC) {
 | 
				
			||||||
			/* If the orders to 'goto depot' are in the orders list (forced servicing),
 | 
								/* If the orders to 'goto depot' are in the orders list (forced servicing),
 | 
				
			||||||
 
 | 
				
			|||||||
							
								
								
									
										11
									
								
								train_cmd.c
									
									
									
									
									
								
							
							
						
						
									
										11
									
								
								train_cmd.c
									
									
									
									
									
								
							@@ -1948,6 +1948,17 @@ int32 CmdSendTrainToDepot(TileIndex tile, uint32 flags, uint32 p1, uint32 p2)
 | 
				
			|||||||
	if (v->vehstatus & VS_CRASHED) return CMD_ERROR;
 | 
						if (v->vehstatus & VS_CRASHED) return CMD_ERROR;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
						if (v->current_order.type == OT_GOTO_DEPOT) {
 | 
				
			||||||
 | 
							if ((p2 & DEPOT_SERVICE) == (bool)HASBIT(v->current_order.flags, OFB_HALT_IN_DEPOT)) {
 | 
				
			||||||
 | 
								/* We called with a different DEPOT_SERVICE setting.
 | 
				
			||||||
 | 
								* Now we change the setting to apply the new one and let the vehicle head for the same depot.
 | 
				
			||||||
 | 
								* Note: the if is (true for requesting service == true for ordered to stop in depot)          */
 | 
				
			||||||
 | 
								if (flags & DC_EXEC) {
 | 
				
			||||||
 | 
									TOGGLEBIT(v->current_order.flags, OFB_HALT_IN_DEPOT);
 | 
				
			||||||
 | 
									InvalidateWindowWidget(WC_VEHICLE_VIEW, v->index, STATUS_BAR);
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
 | 
								return 0;
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
							if (p2 & DEPOT_DONT_CANCEL) return CMD_ERROR; // Requested no cancelation of depot orders
 | 
				
			||||||
		if (flags & DC_EXEC) {
 | 
							if (flags & DC_EXEC) {
 | 
				
			||||||
			if (HASBIT(v->current_order.flags, OFB_PART_OF_ORDERS)) {
 | 
								if (HASBIT(v->current_order.flags, OFB_PART_OF_ORDERS)) {
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user