Merge branch 'master' into jgrpp
# Conflicts: # regression/regression/result.txt # src/aircraft_cmd.cpp # src/airport_gui.cpp # src/articulated_vehicles.cpp # src/console_cmds.cpp # src/date_gui.cpp # src/engine.cpp # src/genworld_gui.cpp # src/gfx_layout_fallback.cpp # src/group_gui.cpp # src/hotkeys.cpp # src/network/core/tcp_connect.cpp # src/network/core/tcp_listen.h # src/newgrf.cpp # src/newgrf.h # src/newgrf_engine.cpp # src/newgrf_gui.cpp # src/newgrf_station.cpp # src/openttd.cpp # src/order_gui.cpp # src/os/macosx/osx_main.cpp # src/pathfinder/yapf/yapf_node_rail.hpp # src/rail_gui.cpp # src/saveload/afterload.cpp # src/saveload/cargopacket_sl.cpp # src/saveload/linkgraph_sl.cpp # src/saveload/station_sl.cpp # src/script/api/script_industrytype.cpp # src/settings.cpp # src/settings_gui.cpp # src/settings_table.cpp # src/settingsgen/settingsgen.cpp # src/station.cpp # src/station_cmd.cpp # src/strings.cpp # src/timer/timer_game_calendar.cpp # src/timer/timer_game_calendar.h # src/timer/timer_manager.h # src/timer/timer_window.cpp # src/timetable_cmd.cpp # src/toolbar_gui.cpp # src/town_cmd.cpp # src/town_gui.cpp # src/train_gui.cpp # src/vehicle_cmd.h # src/vehicle_gui.cpp # src/viewport.cpp # src/widgets/dropdown.cpp # src/window_func.h # src/window_gui.h
This commit is contained in:
@@ -256,11 +256,11 @@ protected:
|
||||
for (const StoryPage *p : this->story_pages) {
|
||||
bool current_page = p->index == this->selected_page_id;
|
||||
if (!p->title.empty()) {
|
||||
list.emplace_back(new DropDownListStringItem(p->title, p->index, current_page));
|
||||
list.push_back(std::make_unique<DropDownListStringItem>(p->title, p->index, current_page));
|
||||
} else {
|
||||
/* No custom title => use a generic page title with page number. */
|
||||
SetDParam(0, page_num);
|
||||
list.emplace_back(new DropDownListStringItem(STR_STORY_BOOK_GENERIC_PAGE_ITEM, p->index, current_page));
|
||||
list.push_back(std::make_unique<DropDownListStringItem>(STR_STORY_BOOK_GENERIC_PAGE_ITEM, p->index, current_page));
|
||||
}
|
||||
page_num++;
|
||||
}
|
||||
@@ -625,8 +625,8 @@ public:
|
||||
*/
|
||||
void UpdatePrevNextDisabledState()
|
||||
{
|
||||
this->SetWidgetDisabledState(WID_SB_PREV_PAGE, story_pages.size() == 0 || this->IsFirstPageSelected());
|
||||
this->SetWidgetDisabledState(WID_SB_NEXT_PAGE, story_pages.size() == 0 || this->IsLastPageSelected());
|
||||
this->SetWidgetDisabledState(WID_SB_PREV_PAGE, story_pages.empty() || this->IsFirstPageSelected());
|
||||
this->SetWidgetDisabledState(WID_SB_NEXT_PAGE, story_pages.empty() || this->IsLastPageSelected());
|
||||
this->SetWidgetDirty(WID_SB_PREV_PAGE);
|
||||
this->SetWidgetDirty(WID_SB_NEXT_PAGE);
|
||||
}
|
||||
@@ -872,7 +872,7 @@ public:
|
||||
this->BuildStoryPageList();
|
||||
|
||||
/* Was the last page removed? */
|
||||
if (this->story_pages.size() == 0) {
|
||||
if (this->story_pages.empty()) {
|
||||
this->selected_generic_title.clear();
|
||||
}
|
||||
|
||||
@@ -880,14 +880,14 @@ public:
|
||||
if (!_story_page_pool.IsValidID(this->selected_page_id)) {
|
||||
this->selected_page_id = INVALID_STORY_PAGE;
|
||||
}
|
||||
if (this->selected_page_id == INVALID_STORY_PAGE && this->story_pages.size() > 0) {
|
||||
if (this->selected_page_id == INVALID_STORY_PAGE && !this->story_pages.empty()) {
|
||||
/* No page is selected, but there exist at least one available.
|
||||
* => Select first page.
|
||||
*/
|
||||
this->SetSelectedPage(this->story_pages[0]->index);
|
||||
}
|
||||
|
||||
this->SetWidgetDisabledState(WID_SB_SEL_PAGE, this->story_pages.size() == 0);
|
||||
this->SetWidgetDisabledState(WID_SB_SEL_PAGE, this->story_pages.empty());
|
||||
this->SetWidgetDirty(WID_SB_SEL_PAGE);
|
||||
this->UpdatePrevNextDisabledState();
|
||||
} else if (data >= 0 && this->selected_page_id == data) {
|
||||
|
Reference in New Issue
Block a user