diff --git a/src/train.h b/src/train.h index 04e2e450b1..0b679a45a9 100644 --- a/src/train.h +++ b/src/train.h @@ -353,7 +353,7 @@ CommandCost CmdMoveRailVehicle(TileIndex, DoCommandFlag , uint32, uint32, const CommandCost CmdMoveVirtualRailVehicle(TileIndex, DoCommandFlag, uint32, uint32, const char*); Train* CmdBuildVirtualRailWagon(const Engine*); -Train* CmdBuildVirtualRailVehicle(EngineID, bool lax_engine_check, StringID &error); +Train* CmdBuildVirtualRailVehicle(EngineID, StringID &error); #define FOR_ALL_TRAINS(var) FOR_ALL_VEHICLES_OF_TYPE(Train, var) diff --git a/src/train_cmd.cpp b/src/train_cmd.cpp index 21f3593a98..dd91d4d28f 100644 --- a/src/train_cmd.cpp +++ b/src/train_cmd.cpp @@ -4149,22 +4149,14 @@ Train* CmdBuildVirtualRailWagon(const Engine *e) return v; } -Train* CmdBuildVirtualRailVehicle(EngineID eid, bool lax_engine_check, StringID &error) +Train* CmdBuildVirtualRailVehicle(EngineID eid, StringID &error) { - if (lax_engine_check) { - const Engine *e = Engine::GetIfValid(eid); - if (e == NULL || e->type != VEH_TRAIN) { - error = STR_ERROR_RAIL_VEHICLE_NOT_AVAILABLE + VEH_TRAIN; - return NULL; - } - } else { - if (!IsEngineBuildable(eid, VEH_TRAIN, _current_company)) { - error = STR_ERROR_RAIL_VEHICLE_NOT_AVAILABLE + VEH_TRAIN; - return NULL; - } + const Engine *e = Engine::GetIfValid(eid); + if (e == nullptr || e->type != VEH_TRAIN) { + error = STR_ERROR_RAIL_VEHICLE_NOT_AVAILABLE + VEH_TRAIN; + return nullptr; } - const Engine* e = Engine::Get(eid); const RailVehicleInfo *rvi = &e->u.rail; int num_vehicles = (e->u.rail.railveh_type == RAILVEH_MULTIHEAD ? 2 : 1) + CountArticulatedParts(eid, false); @@ -4250,7 +4242,7 @@ CommandCost CmdBuildVirtualRailVehicle(TileIndex tile, DoCommandFlag flags, uint if (should_execute) { StringID err = INVALID_STRING_ID; - Train* train = CmdBuildVirtualRailVehicle(eid, false, err); + Train* train = CmdBuildVirtualRailVehicle(eid, err); if (train == NULL) { return_cmd_error(err); diff --git a/src/vehicle_cmd.cpp b/src/vehicle_cmd.cpp index dd706b7a5a..a910658543 100644 --- a/src/vehicle_cmd.cpp +++ b/src/vehicle_cmd.cpp @@ -946,13 +946,13 @@ Train* VirtualTrainFromTemplateVehicle(TemplateVehicle* tv, StringID &err) assert(tv->owner == _current_company); - head = CmdBuildVirtualRailVehicle(tv->engine_type, true, err); - if (!head) return NULL; + head = CmdBuildVirtualRailVehicle(tv->engine_type, err); + if (!head) return nullptr; tail = head; tv = tv->GetNextUnit(); while (tv) { - tmp = CmdBuildVirtualRailVehicle(tv->engine_type, true, err); + tmp = CmdBuildVirtualRailVehicle(tv->engine_type, err); if (!tmp) { CmdDeleteVirtualTrain(INVALID_TILE, DC_EXEC, head->index, 0, NULL); return NULL; @@ -998,13 +998,13 @@ CommandCost CmdVirtualTrainFromTrain(TileIndex tile, DoCommandFlag flags, uint32 Train *tmp, *head, *tail; StringID err = INVALID_STRING_ID; - head = CmdBuildVirtualRailVehicle(train->engine_type, false, err); + head = CmdBuildVirtualRailVehicle(train->engine_type, err); if (!head) return_cmd_error(err); tail = head; train = train->GetNextUnit(); while (train) { - tmp = CmdBuildVirtualRailVehicle(train->engine_type, false, err); + tmp = CmdBuildVirtualRailVehicle(train->engine_type, err); if (!tmp) { CmdDeleteVirtualTrain(tile, flags, head->index, 0, NULL); return_cmd_error(err); @@ -1136,8 +1136,9 @@ CommandCost CmdTemplateVehicleFromTrain(TileIndex tile, DoCommandFlag flags, uin return CMD_ERROR; } - for (Train *v = clicked; v != NULL; v = v->GetNextUnit()) { - if (!IsEngineBuildable(v->engine_type, VEH_TRAIN, _current_company)) { + for (Train *v = clicked; v != nullptr; v = v->GetNextUnit()) { + const Engine *e = Engine::GetIfValid(v->engine_type); + if (e == nullptr || e->type != VEH_TRAIN) { return_cmd_error(STR_ERROR_RAIL_VEHICLE_NOT_AVAILABLE + VEH_TRAIN); } }