diff --git a/src/pbs.cpp b/src/pbs.cpp index 133293909f..139ded7f34 100644 --- a/src/pbs.cpp +++ b/src/pbs.cpp @@ -107,8 +107,7 @@ bool TryReserveRailTrack(TileIndex tile, Track t, bool trigger_stations) case MP_ROAD: if (IsLevelCrossing(tile) && !HasCrossingReservation(tile)) { SetCrossingReservation(tile, true); - BarCrossing(tile); - MarkTileDirtyByTile(tile); // crossing barred, make tile dirty + UpdateLevelCrossing(tile, false); return true; } break; diff --git a/src/road_cmd.cpp b/src/road_cmd.cpp index aa445eb91a..eb06e7af65 100644 --- a/src/road_cmd.cpp +++ b/src/road_cmd.cpp @@ -1638,6 +1638,14 @@ static TrackStatus GetTileTrackStatus_Road(TileIndex tile, TransportType mode, u trackdirbits = TrackBitsToTrackdirBits(AxisToTrackBits(axis)); if (IsCrossingBarred(tile)) red_signals = trackdirbits; + if (IsLevelCrossingTile(TileAddByDiagDir(tile, AxisToDiagDir(axis))) && + IsCrossingBarred(TileAddByDiagDir(tile, AxisToDiagDir(axis)))) { + red_signals &= (TrackdirBits)0x0102; // magic value. I think TRACKBIT_X_SW and TRACKBIT_X_NE should be swapped + } + if (IsLevelCrossingTile(TileAddByDiagDir(tile, ReverseDiagDir(AxisToDiagDir(axis)))) && + IsCrossingBarred(TileAddByDiagDir(tile, ReverseDiagDir(AxisToDiagDir(axis))))) { + red_signals &= (TrackdirBits)0x0201; // inverse of above magic value + } break; } diff --git a/src/train_cmd.cpp b/src/train_cmd.cpp index 8f20973b35..552bbfa97c 100644 --- a/src/train_cmd.cpp +++ b/src/train_cmd.cpp @@ -1676,19 +1676,31 @@ static bool TrainApproachingCrossing(TileIndex tile) return HasVehicleOnPos(tile_from, &tile, &TrainApproachingCrossingEnum); } +/** Check if the crossing should be closed + * @return train on crossing || train approaching crossing || reserved + */ +static inline bool CheckLevelCrossing(TileIndex tile) +{ + return HasCrossingReservation(tile) || HasVehicleOnPos(tile, NULL, &TrainOnTileEnum) || TrainApproachingCrossing(tile); +} /** * Sets correct crossing state * @param tile tile to update * @param sound should we play sound? + * @param force_state force close the crossing due to an adjacent tile * @pre tile is a rail-road crossing */ -void UpdateLevelCrossing(TileIndex tile, bool sound) +static void UpdateLevelCrossingTile(TileIndex tile, bool sound, bool force_state = false) { assert(IsLevelCrossingTile(tile)); + bool new_state; - /* train on crossing || train approaching crossing || reserved */ - bool new_state = HasVehicleOnPos(tile, NULL, &TrainOnTileEnum) || TrainApproachingCrossing(tile) || HasCrossingReservation(tile); + if (force_state) { + new_state = force_state; + } else { + new_state = CheckLevelCrossing(tile); + } if (new_state != IsCrossingBarred(tile)) { if (new_state && sound) { @@ -1699,6 +1711,33 @@ void UpdateLevelCrossing(TileIndex tile, bool sound) } } +/** + * Cycles the adjacent crossings and sets their state + * @param tile tile to update + * @param sound should we play sound? + */ +void UpdateLevelCrossing(TileIndex tile, bool sound) +{ + bool is_forced = false; + if (!IsLevelCrossingTile(tile)) return; + + Axis axis = GetCrossingRoadAxis(tile); + + for (TileIndex t = tile; !is_forced && IsLevelCrossingTile(t) && GetCrossingRoadAxis(t) == axis; t = TileAddByDiagDir(t, AxisToDiagDir(GetCrossingRoadAxis(t)))) { + is_forced |= CheckLevelCrossing(t); + } + for (TileIndex t = tile; !is_forced && IsLevelCrossingTile(t) && GetCrossingRoadAxis(t) == axis; t = TileAddByDiagDir(t, ReverseDiagDir(AxisToDiagDir(GetCrossingRoadAxis(t))))) { + is_forced |= CheckLevelCrossing(t); + } + + for (TileIndex t = tile; IsLevelCrossingTile(t) && GetCrossingRoadAxis(t) == axis; t = TileAddByDiagDir(t, AxisToDiagDir(GetCrossingRoadAxis(t)))) { + UpdateLevelCrossingTile(t, sound, is_forced); + } + for (TileIndex t = tile; IsLevelCrossingTile(t) && GetCrossingRoadAxis(t) == axis; t = TileAddByDiagDir(t, ReverseDiagDir(AxisToDiagDir(GetCrossingRoadAxis(t))))) { + UpdateLevelCrossingTile(t, sound, is_forced); + } +} + /** * Bars crossing and plays ding-ding sound if not barred already @@ -1708,9 +1747,8 @@ void UpdateLevelCrossing(TileIndex tile, bool sound) static inline void MaybeBarCrossingWithSound(TileIndex tile) { if (!IsCrossingBarred(tile)) { - BarCrossing(tile); - if (_settings_client.sound.ambient) SndPlayTileFx(SND_0E_LEVEL_CROSSING, tile); - MarkTileDirtyByTile(tile); + SetCrossingReservation(tile, true); + UpdateLevelCrossing(tile, true); } }