dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid undefined behaviour const_casting std::string c_str()

Browse Source 
Use non-const data() instead

See: #224
This commit is contained in:
Jonathan G Rennison
2021-03-11 01:08:33 +00:00
parent 63d1fe4419
commit 4361a6dbf4
10 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/openttd.cpp
View File

@@ -353,7 +353,7 @@ static void WriteSavegameDebugData(const char *name)
if (_load_check_data.debug_log_data.size()) {
p += seprintf(p, buflast, "%u bytes of debug log data in savegame\n", (uint) _load_check_data.debug_log_data.size());
std::string buffer = _load_check_data.debug_log_data;
ProcessLineByLine(const_cast<char *>(buffer.data()), [&](const char *line) {
ProcessLineByLine(buffer.data(), [&](const char *line) {
if (buflast - p <= 1024) bump_size();
p += seprintf(p, buflast, "> %s\n", line);
});
@@ -363,7 +363,7 @@ static void WriteSavegameDebugData(const char *name)
if (_load_check_data.debug_config_data.size()) {
p += seprintf(p, buflast, "%u bytes of debug config data in savegame\n", (uint) _load_check_data.debug_config_data.size());
std::string buffer = _load_check_data.debug_config_data;
ProcessLineByLine(const_cast<char *>(buffer.data()), [&](const char *line) {
ProcessLineByLine(buffer.data(), [&](const char *line) {
if (buflast - p <= 1024) bump_size();
p += seprintf(p, buflast, "> %s\n", line);
});