Fix: TextfileWindow called virtual methods before constructor completed. (#11889)
SetStringParameters() was called during widget tree init in the constructor.
Calls within a constructor cannot call the derived classes methods. This would result in invalid data being passed to the string system, which could then crash.
(cherry picked from commit fef0bfcfd3
)
This commit is contained in:

committed by
Jonathan G Rennison

parent
a7c2f489f6
commit
4bf9c123d3
@@ -573,6 +573,8 @@ struct NewGRFTextfileWindow : public TextfileWindow {
|
||||
|
||||
NewGRFTextfileWindow(TextfileType file_type, const GRFConfig *c) : TextfileWindow(file_type), grf_config(c)
|
||||
{
|
||||
this->ConstructWindow();
|
||||
|
||||
const char *textfile = this->grf_config->GetTextfile(file_type);
|
||||
this->LoadTextfile(textfile, NEWGRF_DIR);
|
||||
}
|
||||
|
Reference in New Issue
Block a user