(svn r2294) - CodeChange: check the service interval settings when changing of all vehicle-types. To simplify things introduce GetServiceIntervalClamped() that returns the same or clamped value of the new service interval. There were some inconsistencies in the gui files so I had to change those, and const correctness kicked in, so it's a bit messy at certain points.
This commit is contained in:
15
ship_cmd.c
15
ship_cmd.c
@@ -51,7 +51,7 @@ void DrawShipEngineInfo(int engine, int x, int y, int maxw)
|
||||
DrawStringMultiCenter(x, y, STR_982E_COST_MAX_SPEED_CAPACITY, maxw);
|
||||
}
|
||||
|
||||
int GetShipImage(Vehicle *v, byte direction)
|
||||
int GetShipImage(const Vehicle *v, byte direction)
|
||||
{
|
||||
int spritenum = v->spritenum;
|
||||
|
||||
@@ -1032,19 +1032,24 @@ int32 CmdSendShipToDepot(int x, int y, uint32 flags, uint32 p1, uint32 p2)
|
||||
return 0;
|
||||
}
|
||||
|
||||
/** Change the service interval for ships.
|
||||
* @param x,y unused
|
||||
* @param p1 vehicle ID that is being service-interval-changed
|
||||
* @param p2 new service interval
|
||||
*/
|
||||
int32 CmdChangeShipServiceInt(int x, int y, uint32 flags, uint32 p1, uint32 p2)
|
||||
{
|
||||
Vehicle *v;
|
||||
uint16 serv_int = GetServiceIntervalClamped(p2); /* Double check the service interval from the user-input */
|
||||
|
||||
if (!IsVehicleIndex(p1)) return CMD_ERROR;
|
||||
if (serv_int != p2 || !IsVehicleIndex(p1)) return CMD_ERROR;
|
||||
|
||||
v = GetVehicle(p1);
|
||||
|
||||
if (v->type != VEH_Ship || !CheckOwnership(v->owner))
|
||||
return CMD_ERROR;
|
||||
if (v->type != VEH_Ship || !CheckOwnership(v->owner)) return CMD_ERROR;
|
||||
|
||||
if (flags & DC_EXEC) {
|
||||
v->service_interval = (uint16)p2;
|
||||
v->service_interval = serv_int;
|
||||
InvalidateWindowWidget(WC_VEHICLE_DETAILS, v->index, 7);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user