dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(svn r15144) -Codechange: make sure we don't run out of bounds while determining old savegame name

Browse Source 
Note this can't happen in current code
This commit is contained in:
smatz
2009-01-18 22:44:53 +00:00
parent a4865b0cab
commit 575a3a4563
4 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/saveload/oldloader.cpp
View File

@@ -25,6 +25,7 @@
#include "../variables.h"
#include "../strings_func.h"
#include "../effectvehicle_base.h"
#include "../string_func.h"
#include "table/strings.h"
@@ -1571,19 +1572,23 @@ bool LoadOldSaveGame(const char *file)
return true;
}
void GetOldSaveGameName(char *title, const char *path, const char *file)
void GetOldSaveGameName(const char *path, const char *file, char *title, const char *last)
{
char filename[MAX_PATH];
FILE *f;
char temp[HEADER_SIZE - 1];
snprintf(filename, lengthof(filename), "%s" PATHSEP "%s", path, file);
f = fopen(filename, "rb");
title[0] = '\0';
title[48] = '\0';
FILE *f = fopen(filename, "rb");
temp[0] = '\0';
temp[HEADER_SIZE - 2] = '\0';
if (f == NULL) return;
if (fread(title, 1, 48, f) != 48) snprintf(title, 48, "Corrupt file");
if (fread(temp, 1, HEADER_SIZE - 2, f) != HEADER_SIZE - 2) {
seprintf(title, last, "Corrupt file");
} else {
seprintf(title, last, temp);
}
fclose(f);
}