(svn r13387) -Fix: industry directory sorting not working correctly (= != ==)

This commit is contained in:
rubidium
2008-06-05 11:34:26 +00:00
parent e8767f730a
commit 5990a92bca

View File

@@ -806,13 +806,13 @@ protected:
static int CDECL IndustryTypeSorter(const Industry* const *a, const Industry* const *b) static int CDECL IndustryTypeSorter(const Industry* const *a, const Industry* const *b)
{ {
int r = (*a)->type - (*b)->type; int r = (*a)->type - (*b)->type;
return (r = 0) ? IndustryNameSorter(a, b) : r; return (r == 0) ? IndustryNameSorter(a, b) : r;
} }
/** Sort industries by production and name */ /** Sort industries by production and name */
static int CDECL IndustryProductionSorter(const Industry* const *a, const Industry* const *b) static int CDECL IndustryProductionSorter(const Industry* const *a, const Industry* const *b)
{ {
int r; int r = 0;
if ((*a)->produced_cargo[0] == CT_INVALID) { if ((*a)->produced_cargo[0] == CT_INVALID) {
if ((*b)->produced_cargo[0] != CT_INVALID) return -1; if ((*b)->produced_cargo[0] != CT_INVALID) return -1;
@@ -823,14 +823,14 @@ protected:
((*b)->last_month_production[0] + (*b)->last_month_production[1]); ((*b)->last_month_production[0] + (*b)->last_month_production[1]);
} }
return (r = 0) ? IndustryNameSorter(a, b) : r; return (r == 0) ? IndustryNameSorter(a, b) : r;
} }
/** Sort industries by transported cargo and name */ /** Sort industries by transported cargo and name */
static int CDECL IndustryTransportedCargoSorter(const Industry* const *a, const Industry* const *b) static int CDECL IndustryTransportedCargoSorter(const Industry* const *a, const Industry* const *b)
{ {
int r = GetCargoTransportedSortValue(*a) - GetCargoTransportedSortValue(*b); int r = GetCargoTransportedSortValue(*a) - GetCargoTransportedSortValue(*b);
return (r = 0) ? IndustryNameSorter(a, b) : r; return (r == 0) ? IndustryNameSorter(a, b) : r;
} }
/** Sort the industries list */ /** Sort the industries list */