dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(svn r13104) -Codechange: make ResetObjectToPlace safe to be called recursively via the OnPlaceObjectAbort callback and use this knowledge to simplify closing some windows.

Browse Source
This commit is contained in:
rubidium
2008-05-15 14:41:56 +00:00
parent 8fff6e8638
commit 5ae795953a
6 changed files with 29 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/dock_gui.cpp
View File

@@ -175,11 +175,8 @@ static void BuildDocksToolbWndProc(Window *w, WindowEvent *e)
case WE_ABORT_PLACE_OBJ:
w->RaiseButtons();
w = FindWindowById(WC_BUILD_STATION, 0);
if (w != NULL) WP(w, def_d).close = true;
w = FindWindowById(WC_BUILD_DEPOT, 0);
if (w != NULL) WP(w, def_d).close = true;
delete FindWindowById(WC_BUILD_STATION, 0);
delete FindWindowById(WC_BUILD_DEPOT, 0);
break;
case WE_PLACE_PRESIZE: {
@@ -241,7 +238,6 @@ static void BuildDockStationWndProc(Window *w, WindowEvent *e)
case WE_PAINT: {
int rad = (_patches.modified_catchment) ? CA_DOCK : CA_UNMODIFIED;
if (WP(w, def_d).close) return;
DrawWindowWidgets(w);
if (_station_show_coverage) {
@@ -275,16 +271,11 @@ static void BuildDockStationWndProc(Window *w, WindowEvent *e)
break;
case WE_TICK:
if (WP(w, def_d).close) {
delete w;
return;
}
CheckRedrawStationCoverage(w);
break;
case WE_DESTROY:
if (!WP(w, def_d).close) ResetObjectToPlace();
ResetObjectToPlace();
break;
}
}
@@ -349,12 +340,8 @@ static void BuildDocksDepotWndProc(Window *w, WindowEvent *e)
}
} break;
case WE_TICK:
if (WP(w, def_d).close) delete w;
break;
case WE_DESTROY:
if (!WP(w, def_d).close) ResetObjectToPlace();
ResetObjectToPlace();
break;
}
}