TBTR: Fix virtual trains being created at load using wrong company.
Fix virtual trains showing up in company engine counts.
This commit is contained in:
@@ -139,7 +139,7 @@ void GroupStatistics::Clear()
|
|||||||
/* static */ void GroupStatistics::CountVehicle(const Vehicle *v, int delta)
|
/* static */ void GroupStatistics::CountVehicle(const Vehicle *v, int delta)
|
||||||
{
|
{
|
||||||
/* make virtual trains group-neutral */
|
/* make virtual trains group-neutral */
|
||||||
if ( HasBit(v->subtype, GVSF_VIRTUAL) ) return;
|
if (HasBit(v->subtype, GVSF_VIRTUAL)) return;
|
||||||
|
|
||||||
assert(delta == 1 || delta == -1);
|
assert(delta == 1 || delta == -1);
|
||||||
|
|
||||||
@@ -164,6 +164,9 @@ void GroupStatistics::Clear()
|
|||||||
*/
|
*/
|
||||||
/* static */ void GroupStatistics::CountEngine(const Vehicle *v, int delta)
|
/* static */ void GroupStatistics::CountEngine(const Vehicle *v, int delta)
|
||||||
{
|
{
|
||||||
|
/* make virtual trains group-neutral */
|
||||||
|
if (HasBit(v->subtype, GVSF_VIRTUAL)) return;
|
||||||
|
|
||||||
assert(delta == 1 || delta == -1);
|
assert(delta == 1 || delta == -1);
|
||||||
GroupStatistics::GetAllGroup(v).num_engines[v->engine_type] += delta;
|
GroupStatistics::GetAllGroup(v).num_engines[v->engine_type] += delta;
|
||||||
GroupStatistics::Get(v).num_engines[v->engine_type] += delta;
|
GroupStatistics::Get(v).num_engines[v->engine_type] += delta;
|
||||||
|
@@ -3,6 +3,7 @@
|
|||||||
#include "../tbtr_template_vehicle.h"
|
#include "../tbtr_template_vehicle.h"
|
||||||
#include "../tbtr_template_vehicle_func.h"
|
#include "../tbtr_template_vehicle_func.h"
|
||||||
#include "../train.h"
|
#include "../train.h"
|
||||||
|
#include "../core/backup_type.hpp"
|
||||||
|
|
||||||
#include "saveload.h"
|
#include "saveload.h"
|
||||||
|
|
||||||
@@ -102,6 +103,7 @@ void AfterLoadTemplateVehiclesUpdateImage()
|
|||||||
|
|
||||||
FOR_ALL_TEMPLATES(tv) {
|
FOR_ALL_TEMPLATES(tv) {
|
||||||
if (tv->Prev() == NULL) {
|
if (tv->Prev() == NULL) {
|
||||||
|
Backup<CompanyByte> cur_company(_current_company, tv->owner, FILE_LINE);
|
||||||
StringID err;
|
StringID err;
|
||||||
Train* t = VirtualTrainFromTemplateVehicle(tv, err);
|
Train* t = VirtualTrainFromTemplateVehicle(tv, err);
|
||||||
if (t != NULL) {
|
if (t != NULL) {
|
||||||
@@ -123,6 +125,7 @@ void AfterLoadTemplateVehiclesUpdateImage()
|
|||||||
}
|
}
|
||||||
delete t;
|
delete t;
|
||||||
}
|
}
|
||||||
|
cur_company.Restore();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -653,6 +653,7 @@ uint CountVehiclesInChain(const Vehicle *v)
|
|||||||
*/
|
*/
|
||||||
bool Vehicle::IsEngineCountable() const
|
bool Vehicle::IsEngineCountable() const
|
||||||
{
|
{
|
||||||
|
if (HasBit(this->subtype, GVSF_VIRTUAL)) return false;
|
||||||
switch (this->type) {
|
switch (this->type) {
|
||||||
case VEH_AIRCRAFT: return Aircraft::From(this)->IsNormalAircraft(); // don't count plane shadows and helicopter rotors
|
case VEH_AIRCRAFT: return Aircraft::From(this)->IsNormalAircraft(); // don't count plane shadows and helicopter rotors
|
||||||
case VEH_TRAIN:
|
case VEH_TRAIN:
|
||||||
|
@@ -919,6 +919,10 @@ CommandCost CmdVirtualTrainFromTemplateVehicle(TileIndex tile, DoCommandFlag fla
|
|||||||
return CMD_ERROR;
|
return CMD_ERROR;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (tv->owner != _current_company) {
|
||||||
|
return CMD_ERROR;
|
||||||
|
}
|
||||||
|
|
||||||
bool should_execute = (flags & DC_EXEC) != 0;
|
bool should_execute = (flags & DC_EXEC) != 0;
|
||||||
|
|
||||||
if (should_execute) {
|
if (should_execute) {
|
||||||
@@ -940,6 +944,8 @@ Train* VirtualTrainFromTemplateVehicle(TemplateVehicle* tv, StringID &err)
|
|||||||
CommandCost c;
|
CommandCost c;
|
||||||
Train *tmp, *head, *tail;
|
Train *tmp, *head, *tail;
|
||||||
|
|
||||||
|
assert(tv->owner == _current_company);
|
||||||
|
|
||||||
head = CmdBuildVirtualRailVehicle(tv->engine_type, true, err);
|
head = CmdBuildVirtualRailVehicle(tv->engine_type, true, err);
|
||||||
if (!head) return NULL;
|
if (!head) return NULL;
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user