From 6c2152045a651ec3ed483240ebab64cfbce1beb0 Mon Sep 17 00:00:00 2001 From: Andreas Schmitt Date: Thu, 17 Jun 2021 07:56:51 +0200 Subject: [PATCH] Fix banding issue in artic tree range Using tile index for randomization is a very very very bad idea --- src/tree_cmd.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/tree_cmd.cpp b/src/tree_cmd.cpp index 7ae01c5dac..fd973bf40a 100644 --- a/src/tree_cmd.cpp +++ b/src/tree_cmd.cpp @@ -194,8 +194,7 @@ static TreeType GetRandomTreeType(TileIndex tile, uint seed) uint normalised_distance = (height_above_snow_line < 0) ? -height_above_snow_line : height_above_snow_line + 1; bool arctic_tree = false; if (normalised_distance < lengthof(_arctic_tree_occurance)) { - uint adjusted_seed = (seed ^ tile) & 0xFF; - arctic_tree = adjusted_seed < _arctic_tree_occurance[normalised_distance]; + arctic_tree = RandomRange(256) < _arctic_tree_occurance[normalised_distance]; } if (height_above_snow_line < 0) { /* Below snow level mixed forest. */