From 8098274892827e2150a573853fb62e1de0285422 Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Wed, 24 Mar 2021 23:49:36 +0000 Subject: [PATCH] Fix tile iterator leak when building river/canal See: https://github.com/OpenTTD/OpenTTD/pull/8880#issuecomment-806253149 --- src/water_cmd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/water_cmd.cpp b/src/water_cmd.cpp index 3770048ae2..9fb23c47ac 100644 --- a/src/water_cmd.cpp +++ b/src/water_cmd.cpp @@ -479,7 +479,7 @@ CommandCost CmdBuildCanal(TileIndex tile, DoCommandFlag flags, uint32 p1, uint32 CommandCost cost(EXPENSES_CONSTRUCTION); - TileIterator *iter = HasBit(p2, 2) ? (TileIterator *)new DiagonalTileIterator(tile, p1) : new OrthogonalTileIterator(tile, p1); + std::unique_ptr iter(HasBit(p2, 2) ? (TileIterator *)new DiagonalTileIterator(tile, p1) : new OrthogonalTileIterator(tile, p1)); for (; *iter != INVALID_TILE; ++(*iter)) { TileIndex tile = *iter; CommandCost ret;