dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix action cost estimation for signal dragging over bridge/tunnels.

Browse Source 
If a bridge/tunnel entrance is signalled, blacklist the far end.
This commit is contained in:
Jonathan G Rennison
2016-09-11 13:20:30 +01:00
parent 888cd1be07
commit 8281041784
1 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/rail_cmd.cpp
View File

@@ -33,6 +33,7 @@
#include "strings_func.h" #include "strings_func.h"
#include "company_gui.h" #include "company_gui.h"
#include "object_map.h" #include "object_map.h"
#include "core/container_func.hpp"
#include "table/strings.h" #include "table/strings.h"
#include "table/railtypes.h" #include "table/railtypes.h"
@@ -1412,10 +1413,22 @@ static CommandCost CmdSignalTrackHelper(TileIndex tile, DoCommandFlag flags, uin
Trackdir last_suitable_trackdir = INVALID_TRACKDIR; Trackdir last_suitable_trackdir = INVALID_TRACKDIR;
CommandCost last_error = CMD_ERROR; CommandCost last_error = CMD_ERROR;
bool had_success = false; bool had_success = false;
std::vector<TileIndex> tunnel_bridge_blacklist;
for (;;) { for (;;) {
/* only build/remove signals with the specified density */ bool tile_ok = true;
if (IsTileType(tile, MP_TUNNELBRIDGE)) {
if (container_unordered_remove(tunnel_bridge_blacklist, tile) > 0) {
/* This tile is blacklisted, skip tile and remove from blacklist.
* Mark last used counter as current tile.
*/
tile_ok = false;
last_used_ctr = signal_ctr;
last_suitable_tile = INVALID_TILE;
}
}
if (remove || minimise_gaps || signal_ctr % signal_density == 0 || IsTileType(tile, MP_TUNNELBRIDGE)) { /* only build/remove signals with the specified density */
if (tile_ok && (remove || minimise_gaps || signal_ctr % signal_density == 0 || IsTileType(tile, MP_TUNNELBRIDGE))) {
uint32 p1 = GB(TrackdirToTrack(trackdir), 0, 3); uint32 p1 = GB(TrackdirToTrack(trackdir), 0, 3);
SB(p1, 3, 1, mode); SB(p1, 3, 1, mode);
SB(p1, 4, 1, semaphores); SB(p1, 4, 1, semaphores);
@@ -1430,6 +1443,10 @@ static CommandCost CmdSignalTrackHelper(TileIndex tile, DoCommandFlag flags, uin
/* Test tiles in between for suitability as well if minimising gaps. */ /* Test tiles in between for suitability as well if minimising gaps. */
bool test_only = !remove && minimise_gaps && signal_ctr < (last_used_ctr + signal_density); bool test_only = !remove && minimise_gaps && signal_ctr < (last_used_ctr + signal_density);
CommandCost ret = DoCommand(tile, p1, signals, test_only ? flags & ~DC_EXEC : flags, remove ? CMD_REMOVE_SIGNALS : CMD_BUILD_SIGNALS); CommandCost ret = DoCommand(tile, p1, signals, test_only ? flags & ~DC_EXEC : flags, remove ? CMD_REMOVE_SIGNALS : CMD_BUILD_SIGNALS);
if (!test_only && ret.Succeeded() && IsTileType(tile, MP_TUNNELBRIDGE) && GetTunnelBridgeDirection(tile) == TrackdirToExitdir(trackdir)) {
/* Blacklist far end of tunnel if we just actioned the near end */
tunnel_bridge_blacklist.push_back(GetOtherTunnelBridgeEnd(tile));
}
if (ret.Succeeded()) { if (ret.Succeeded()) {
/* Remember last track piece where we can place a signal. */ /* Remember last track piece where we can place a signal. */
@@ -1447,6 +1464,10 @@ static CommandCost CmdSignalTrackHelper(TileIndex tile, DoCommandFlag flags, uin
if (HasBit(signal_dir, 1)) signals |= SignalAgainstTrackdir(last_suitable_trackdir); if (HasBit(signal_dir, 1)) signals |= SignalAgainstTrackdir(last_suitable_trackdir);
ret = DoCommand(last_suitable_tile, p1, signals, flags, remove ? CMD_REMOVE_SIGNALS : CMD_BUILD_SIGNALS); ret = DoCommand(last_suitable_tile, p1, signals, flags, remove ? CMD_REMOVE_SIGNALS : CMD_BUILD_SIGNALS);
if (ret.Succeeded() && IsTileType(last_suitable_tile, MP_TUNNELBRIDGE) && GetTunnelBridgeDirection(last_suitable_tile) == TrackdirToExitdir(last_suitable_trackdir)) {
/* Blacklist far end of tunnel if we just actioned the near end */
tunnel_bridge_blacklist.push_back(GetOtherTunnelBridgeEnd(last_suitable_tile));
}
} }
/* Collect cost. */ /* Collect cost. */
@@ -1454,14 +1475,7 @@ static CommandCost CmdSignalTrackHelper(TileIndex tile, DoCommandFlag flags, uin
/* Be user-friendly and try placing signals as much as possible */ /* Be user-friendly and try placing signals as much as possible */
if (ret.Succeeded()) { if (ret.Succeeded()) {
had_success = true; had_success = true;
if (IsTileType(tile, MP_TUNNELBRIDGE)) {
if ((!autofill && GetTunnelBridgeDirection(tile) == TrackdirToExitdir(trackdir)) ||
(autofill && GetTunnelBridgeDirection(tile) != TrackdirToExitdir(trackdir))) {
total_cost.AddCost(ret); total_cost.AddCost(ret);
}
} else {
total_cost.AddCost(ret);
}
last_used_ctr = last_suitable_ctr; last_used_ctr = last_suitable_ctr;
last_suitable_tile = INVALID_TILE; last_suitable_tile = INVALID_TILE;
} else { } else {