dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix packet overflow in ClientNetworkGameSocketHandler::SendDesyncLog

Browse Source
This commit is contained in:
Jonathan G Rennison
2019-06-14 21:56:56 +01:00
parent 1d5ba98932
commit 84d30e2f97
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/network_client.cpp
View File

@@ -483,9 +483,8 @@ NetworkRecvStatus ClientNetworkGameSocketHandler::SendError(NetworkErrorCode err
NetworkRecvStatus ClientNetworkGameSocketHandler::SendDesyncLog(const std::string &log)
{
for (size_t offset = 0; offset < log.size();) {
size_t size = min<size_t>(log.size() - offset, SHRT_MAX - 2);
Packet *p = new Packet(PACKET_CLIENT_DESYNC_LOG);
size_t size = min<size_t>(log.size() - offset, SHRT_MAX - 2 - p->size);
p->Send_uint16(size);
p->Send_binary(log.data() + offset, size);
my_client->SendPacket(p);