dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix incorrect signal offsets in GetAndClearLastBridgeEntranceSetSignalIndex

Browse Source 
Fixes #65
This commit is contained in:
Jonathan G Rennison
2018-08-21 04:22:33 +01:00
parent 53acbd57b1
commit a0ef4ea760
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/train_cmd.cpp
View File

@@ -2224,7 +2224,7 @@ static bool CheckTrainStayInDepot(Train *v)
static int GetAndClearLastBridgeEntranceSetSignalIndex(TileIndex bridge_entrance) static int GetAndClearLastBridgeEntranceSetSignalIndex(TileIndex bridge_entrance)
{ {
uint16 m = _m[bridge_entrance].m2; uint16 m = _m[bridge_entrance].m2;
if (m & 0x8000) { if (m & BRIDGE_M2_SIGNAL_STATE_EXT_FLAG) {
auto it = _long_bridge_signal_sim_map.find(bridge_entrance); auto it = _long_bridge_signal_sim_map.find(bridge_entrance);
if (it != _long_bridge_signal_sim_map.end()) { if (it != _long_bridge_signal_sim_map.end()) {
LongBridgeSignalStorage &lbss = it->second; LongBridgeSignalStorage &lbss = it->second;
@@ -2235,13 +2235,14 @@ static int GetAndClearLastBridgeEntranceSetSignalIndex(TileIndex bridge_entrance
if (slot_bits) { if (slot_bits) {
uint8 i = FindLastBit(slot_bits); uint8 i = FindLastBit(slot_bits);
ClrBit(slot_bits, i); ClrBit(slot_bits, i);
return 1 + 15 + (64 * slot) + i; return 1 + BRIDGE_M2_SIGNAL_STATE_COUNT + (64 * slot) + i;
} }
} }
} }
} }
if (m & 0x7FFF) { uint16 m_masked = GB(m & (~BRIDGE_M2_SIGNAL_STATE_EXT_FLAG), BRIDGE_M2_SIGNAL_STATE_OFFSET, BRIDGE_M2_SIGNAL_STATE_FIELD_SIZE);
uint8 i = FindLastBit(m & 0x7FFF); if (m_masked) {
uint8 i = FindLastBit(m_masked);
ClrBit(_m[bridge_entrance].m2, i); ClrBit(_m[bridge_entrance].m2, i);
return 1 + i; return 1 + i;
} }